allow tests using lsof to pass on ENOENT#3744
Merged
hueniverse merged 1 commit intohapijs:masterfrom Mar 2, 2018
cjihrig:lsof
Merged
allow tests using lsof to pass on ENOENT#3744hueniverse merged 1 commit intohapijs:masterfrom cjihrig:lsof
hueniverse merged 1 commit intohapijs:masterfrom
cjihrig:lsof
Conversation
The tests are currently skipped on Windows, but there are no guarantees that lsof exists on the system executing the tests. Refs: nodejs/citgm#436
Marsup
approved these changes
Feb 21, 2018
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are currently skipped on Windows, but there are no guarantees that
lsofexists on the system executing the tests.Refs: nodejs/citgm#436