Skip to content

allow tests using lsof to pass on ENOENT #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hueniverse merged 1 commit into from
Mar 2, 2018
Merged

allow tests using lsof to pass on ENOENT #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const Path = require('path');
const TLS = require('tls');

const Boom = require('boom');
const Bounce = require('bounce');
const Code = require('code');
const Handlebars = require('handlebars');
const Hapi = require('..');
Expand Down Expand Up @@ -1489,6 +1490,13 @@ describe('Core', () => {

const cmd = ChildProcess.spawn('lsof', ['-p', process.pid]);
let lsof = '';

cmd.on('error', (err) => {

// Allow the test to pass on platforms with no lsof
Bounce.ignore(err, { errno: 'ENOENT' });
});

cmd.stdout.on('data', (buffer) => {

lsof += buffer.toString();
Expand Down
15 changes: 15 additions & 0 deletions test/transmit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const Stream = require('stream');
const Zlib = require('zlib');

const Boom = require('boom');
const Bounce = require('bounce');
const Code = require('code');
const Hapi = require('..');
const Hoek = require('hoek');
Expand Down Expand Up @@ -78,6 +79,13 @@ describe('transmission', () => {

const cmd = ChildProcess.spawn('lsof', ['-p', process.pid]);
let lsof = '';

cmd.on('error', (err) => {

// Allow the test to pass on platforms with no lsof
Bounce.ignore(err, { errno: 'ENOENT' });
});

cmd.stdout.on('data', (buffer) => {

lsof += buffer.toString();
Expand Down Expand Up @@ -112,6 +120,13 @@ describe('transmission', () => {

const cmd = ChildProcess.spawn('lsof', ['-p', process.pid]);
let lsof = '';

cmd.on('error', (err) => {

// Allow the test to pass on platforms with no lsof
Bounce.ignore(err, { errno: 'ENOENT' });
});

cmd.stdout.on('data', (buffer) => {

lsof += buffer.toString();
Expand Down