Optimized check for already cracked hashes #1851
Open
+103
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check, whether hashes from a new hashlist are already cracked in another list, got optimized.
Instead of searching each hashline in the database, the entire comparion got sourced out to the database.
A temporary table of the new hashes is created and via join cracked hashes will be determined.
This will speed up the comparison for lists of a bigger size.
I haven't done comprehensive performance tests, but with my hashtopolis hash table containing 10 million rows and a 500k lines hashfile, I achieved 40 seconds instead of 1 minute and 15 seconds.