Skip to content

Optimized check for already cracked hashes #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Grr1337 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimized check for already cracked hashes #1851

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
948a7a1
Update HashlistUtils.class.php
Grr1337 Dec 28, 2025
5013098
Update HashlistUtils.class.php
Grr1337 Dec 28, 2025
28e7a77
Update HashlistUtils.class.php
Grr1337 Dec 28, 2025
5ddf35c
Update HashlistUtils.class.php
Grr1337 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 103 additions & 52 deletions src/inc/utils/HashlistUtils.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ public static function createHashlist($name, $isSalted, $isSecret, $isHexSalted,
$hashtype = intval($hashtype);
$accessGroup = Factory::getAccessGroupFactory()->get($accessGroupId);
$brainFeatures = intval($brainFeatures);

if ($format < DHashlistFormat::PLAIN || $format > DHashlistFormat::BINARY) {
throw new HTException("Invalid hashlist format!");
}
Expand All @@ -792,11 +792,11 @@ public static function createHashlist($name, $isSalted, $isSecret, $isHexSalted,
else if ($brainId && $brainFeatures < 1 || $brainFeatures > 3) {
throw new HTException("Invalid brain features selected!");
}

Factory::getAgentFactory()->getDB()->beginTransaction();
$hashlist = new Hashlist(null, $name, $format, $hashtype, 0, $separator, 0, $secret, $hexsalted, $salted, $accessGroup->getId(), '', $brainId, $brainFeatures, 0);
$hashlist = Factory::getHashlistFactory()->save($hashlist);

$dataSource = "";
switch ($source) {
case "paste":
Expand All @@ -821,7 +821,6 @@ public static function createHashlist($name, $isSalted, $isSecret, $isHexSalted,
Factory::getAgentFactory()->getDB()->rollback();
throw new HTException("Required file does not exist!");
}
// replace countLines with fileLineCount? Seems like a better option, not OS-dependent
else if (Util::countLines($tmpfile) > SConfig::getInstance()->getVal(DConfig::MAX_HASHLIST_SIZE)) {
Factory::getAgentFactory()->getDB()->rollback();
throw new HTException("Hashlist has too many lines!");
Expand All @@ -833,11 +832,10 @@ public static function createHashlist($name, $isSalted, $isSecret, $isHexSalted,
Factory::getAgentFactory()->getDB()->commit();
$added = 0;
$preFound = 0;

switch ($format) {
case DHashlistFormat::PLAIN:
if ($salted) {
// find out if the first line contains field separator
rewind($file);
$bufline = stream_get_line($file, 1024);
if (strpos($bufline, $saltSeparator) === false) {
Expand All @@ -847,70 +845,123 @@ public static function createHashlist($name, $isSalted, $isSecret, $isHexSalted,
else {
$saltSeparator = "";
}

Factory::getAgentFactory()->getDB()->beginTransaction();
rewind($file);
Factory::getAgentFactory()->getDB()->beginTransaction();
$values = array();
$bufferCount = 0;
while (!feof($file)) {
$line = trim(fgets($file));
if (strlen($line) == 0) {

$db = Factory::getAgentFactory()->getDB();
$db->query(
"CREATE TEMPORARY TABLE tmp_hashes (
hash VARCHAR(1024)
) ENGINE=InnoDB"
);

$statementInsertInTempDb = $db->prepare(
"INSERT INTO tmp_hashes (hash) VALUES (:hash)"
);

$batchSize = 1000;
$batch = [];
rewind($file);

while (($line = fgets($file)) !== false) {
$line = trim($line);
if ($line === '') {
continue;
}
$hash = $line;
$salt = "";
if ($saltSeparator != "") {
$pos = strpos($line, $saltSeparator);
if ($pos !== false) {
$hash = substr($line, 0, $pos);
$salt = substr($line, $pos + 1);
}
}
if (strlen($hash) == 0) {
continue;

if ($saltSeparator !== '') {
$parts = explode($saltSeparator, $line, 2);
$hash = $parts[0];
} else {
$hash = $line;
}
//TODO: check hash length here

// if selected check if it is cracked
$found = null;
if (SConfig::getInstance()->getVal(DConfig::HASHLIST_IMPORT_CHECK)) {
$qF = new QueryFilter(Hash::HASH, $hash, "=");
$check = Factory::getHashFactory()->filter([Factory::FILTER => $qF]);
foreach ($check as $c) {
if ($c->getIsCracked()) {
$found = $c;
break;
}

$batch[] = $hash;

if (count($batch) >= $batchSize) {
foreach ($batch as $h) {
$statementInsertInTempDb->execute([':hash' => $h]);
}
$batch = [];
}
if ($found == null) {
$values[] = new Hash(null, $hashlist->getId(), $hash, $salt, "", 0, null, 0, 0);
}
else {
$values[] = new Hash(null, $hashlist->getId(), $hash, $salt, $found->getPlaintext(), time(), null, 1, 0);
$preFound++;
}

if (count($batch) > 0) {
foreach ($batch as $h) {
$statementInsertInTempDb->execute([':hash' => $h]);
}
$bufferCount++;
if ($bufferCount >= 10000) {
$result = Factory::getHashFactory()->massSave($values);
$added += $result->rowCount();
Factory::getAgentFactory()->getDB()->commit();
Factory::getAgentFactory()->getDB()->beginTransaction();
$values = array();
$bufferCount = 0;
}

$foundHashes = [];
if (SConfig::getInstance()->getVal(DConfig::HASHLIST_IMPORT_CHECK)) {
$sql = "
SELECT *
FROM Hash h
INNER JOIN tmp_hashes t ON h.hash = t.hash
WHERE h.isCracked = 1
";
$stmt = $db->query($sql);
$rows = $stmt->fetchAll(PDO::FETCH_ASSOC);

foreach ($rows as $row) {
$foundHashes[$row['hash']] = Factory::getHashFactory()->createObjectFromDict(
$row['hashId'],
$row
);
}
}

$values = [];
$bufferCount = 0;
rewind($file);
while (($line = fgets($file)) !== false) {
$line = trim($line);
if ($line === '') continue;

if ($saltSeparator !== '') {
$parts = explode($saltSeparator, $line, 2);
$hash = $parts[0];
$salt = $parts[1] ?? "";
} else {
$hash = $line;
$salt = "";
}

$found = $foundHashes[$hash] ?? null;

if ($found == null) {
$values[] = new Hash(null, $hashlist->getId(), $hash, $salt, "", 0, null, 0, 0);
} else {
$values[] = new Hash(null, $hashlist->getId(), $hash, $salt, $found->getPlaintext(), time(), null, 1, 0);
$preFound++;
}

$bufferCount++;
if ($bufferCount >= 10000) {
$result = Factory::getHashFactory()->massSave($values);
$added += $result->rowCount();
Factory::getAgentFactory()->getDB()->commit();
Factory::getAgentFactory()->getDB()->beginTransaction();
$values = [];
$bufferCount = 0;
}
}
if (sizeof($values) > 0) {
$result = Factory::getHashFactory()->massSave($values);
$added += $result->rowCount();
$result = Factory::getHashFactory()->massSave($values);
$added += $result->rowCount();
}

fclose($file);
unlink($tmpfile);

Factory::getHashlistFactory()->mset($hashlist, [Hashlist::HASH_COUNT => $added, Hashlist::CRACKED => $preFound]);
Factory::getAgentFactory()->getDB()->commit();
Util::createLogEntry("User", $user->getId(), DLogEntry::INFO, "New Hashlist created: " . $hashlist->getHashlistName());

NotificationHandler::checkNotifications(DNotificationType::NEW_HASHLIST, new DataSet(array(DPayloadKeys::HASHLIST => $hashlist)));

break;

case DHashlistFormat::WPA:
$added = 0;
$values = [];
Expand Down