-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #11668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughThis PR updates the dependency management strategy for the Stack Overflow plugin by replacing workspace protocol references with explicit semantic version pinning. Four Backstage packages are affected: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Registry as NPM Registry
participant Plugin as Stack Overflow Plugin
Dev->>PM: Run npm/yarn install
PM->>Plugin: Read package.json
Note over Plugin: Dependencies now specify<br/>fixed versions instead of<br/>workspace protocol
alt Dependency uses workspace protocol
PM->>PM: Resolve from local workspace
else Dependency uses fixed version
PM->>Registry: Fetch @backstage/config@0.1.1
Registry-->>PM: Return package
PM->>Registry: Fetch @backstage/core-plugin-api@0.1.0
Registry-->>PM: Return package
PM->>Registry: Fetch @backstage/plugin-search-react@0.1.0
Registry-->>PM: Return package
PM->>Registry: Fetch @backstage/theme@0.1.1
Registry-->>PM: Return package
end
PM->>Plugin: Install dependencies
PM-->>Dev: Installation complete
Note over Dev,Plugin: Plugin now uses fixed versions<br/>from registry instead of<br/>local workspace packages
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by pinning several @backstage dependencies to very old, specific versions. This approach is incorrect and dangerous for a monorepo using Yarn workspaces. It downgrades critical packages, which will likely break the application and violates the intended dependency management strategy. The PR also notes that it failed to update the yarn.lock file, which is another major issue.
I have left a critical review comment on plugins/stack-overflow/package.json explaining why these changes should be rejected and proposing the correct solution: using Yarn's resolutions feature in the root package.json to enforce secure versions of the vulnerable transitive dependencies (tar and eslint). This will resolve the security issues without introducing breaking changes to your project's dependencies.
| "@backstage/config": "0.1.1", | ||
| "@backstage/core-components": "workspace:^", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/plugin-home-react": "workspace:^", | ||
| "@backstage/plugin-search-common": "workspace:^", | ||
| "@backstage/plugin-search-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/plugin-search-react": "0.1.0", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes incorrectly attempt to fix security vulnerabilities by downgrading @backstage packages to very old versions. This will likely break the application and goes against the monorepo's workspace:^ dependency strategy.
The correct way to fix these transitive dependency vulnerabilities (tar and eslint) is to use Yarn's resolutions feature in the root package.json. This allows you to force specific, secure versions of these packages across the entire project without breaking your internal dependencies.
For example, add this to your root package.json and run yarn install:
"resolutions": {
"tar": "^6.2.1",
"eslint": "^8.57.0"
}I've suggested reverting these changes. Please close this PR and apply the fix using resolutions.
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-home-react": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/theme": "workspace:^"
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/stack-overflow/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15127355
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal
EntelligenceAI PR Summary
This PR transitions the Stack Overflow plugin from workspace protocol dependencies to explicit version pinning for Backstage packages.
@backstage/configfromworkspace:^to0.1.1@backstage/themefromworkspace:^to0.1.1@backstage/core-plugin-apifromworkspace:^to0.1.0@backstage/plugin-search-reactfromworkspace:^to0.1.0