Skip to content

[Snyk] Fix for 2 vulnerabilities #11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #11668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/stack-overflow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-home-react": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-search-react": "0.1.0",
"@backstage/theme": "0.1.1",
Comment on lines +25 to +31
Copy link

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly attempt to fix security vulnerabilities by downgrading @backstage packages to very old versions. This will likely break the application and goes against the monorepo's workspace:^ dependency strategy.

The correct way to fix these transitive dependency vulnerabilities (tar and eslint) is to use Yarn's resolutions feature in the root package.json. This allows you to force specific, secure versions of these packages across the entire project without breaking your internal dependencies.

For example, add this to your root package.json and run yarn install:

"resolutions": {
  "tar": "^6.2.1",
  "eslint": "^8.57.0"
}

I've suggested reverting these changes. Please close this PR and apply the fix using resolutions.

    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-home-react": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^",
    "@backstage/plugin-search-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@testing-library/jest-dom": "^5.10.1",
Expand Down
Loading