-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Security upgrade next from 12.3.4 to 15.5.10 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
|
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the next package from version ^14.2.24 to ^15.5.10 to address a security vulnerability. While this is an important security fix, this major version upgrade of Next.js introduces a critical incompatibility. Next.js 15 requires React 19, but this project's dependencies for react and react-dom are still on version 17. This will break the application. Additionally, as noted in the pull request description, the pnpm-lock.yaml file needs to be updated manually. Due to the breaking change, this PR should be handled with care.
| "luxon": "^3.1.0", | ||
| "mysql2": "^2.3.3", | ||
| "next": "^14.2.24", | ||
| "next": "^15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading next to version 15 introduces a requirement for React 19. The react and react-dom dependencies in this package.json are on version 17 (^17.0.2), which is incompatible. This will lead to build failures or runtime errors.
To resolve this, you'll need to also upgrade react and react-dom to a version compatible with Next.js 15 (e.g., 19.0.0-rc.0 or newer) and address any breaking changes from both the Next.js and React upgrades.
Given the complexity of this major version upgrade, you might consider if there's a patch version of next@14 that fixes the vulnerability, or if the usage of next can be removed if it's not essential for this job server.
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
packages/job-server/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling