forked from pingcap/ossinsight
-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Security upgrade next from 12.3.4 to 15.5.10 #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-28dfaf03a1e7acbacfa41f3cff7e6b14
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading
nextto version 15 introduces a requirement for React 19. Thereactandreact-domdependencies in thispackage.jsonare on version 17 (^17.0.2), which is incompatible. This will lead to build failures or runtime errors.To resolve this, you'll need to also upgrade
reactandreact-domto a version compatible with Next.js 15 (e.g.,19.0.0-rc.0or newer) and address any breaking changes from both the Next.js and React upgrades.Given the complexity of this major version upgrade, you might consider if there's a patch version of
next@14that fixes the vulnerability, or if the usage ofnextcan be removed if it's not essential for this job server.