-
Notifications
You must be signed in to change notification settings - Fork 2
Add PHP binary build script #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Related to #161
|
I think not committing them, and uploading them to s3 is still the way to go. |
|
@joehoyle asked in Slack today what version of PHP is used here. It's whatever is in |
|
The PHP version currently available and in use is 7.1. This addition makes it easy to generate binaries for different versions so far but needs to support a configuration option. We may be able to forgo this in favour of just updating the binary and having the config option set a runtime flag for the PHP version 🤔 |
|
Actually the script is still useful but we don’t necessarily need more than one binary available as long as it’s the latest. |
|
This looks great, I also modified the script to also export This was a PHP 8.2 build. I haven't verified that |
|
Agree that I think we just want to use the latest version of PHP, rather than supporting multiple versions; if that can work anyway. |
|
Need to work out how to run these damn tests. I think we might have a hodgepodge of older tests that might not even work |
|
@roborourke if you have any availability any chance you could try work out how to run the tests and get this shipped? I'm a bit snowerd under atm. |
|
FYI we're still running |
Uses Dockerfile suggested by Joe on #161 to generate PHP binaries. I'm not sure if we should just commit the binaries here as they have to be downloaded when building the lambda anyway. We could get maybe 3 binaries in within the 512mb limit for function size.
Usage:
npm run build:php -- <version><version>needs to be a fully qualified version number as it's used to match the PHP source tarballs on GitHub.