Skip to content

Gpugh pagination 1 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grahampugh wants to merge 2 commits into
base: Sdelsaz-patch-1
Choose a base branch
from
Open

Gpugh pagination 1 #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a3f71e
suggestion for pagination
grahampugh Jan 13, 2026
c13133e
remove unneeded line
grahampugh Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 45 additions & 13 deletions services/Framework-Fixer/Framework-Fixer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,24 +231,56 @@ group_name_prompt() {
# Check if the command was successful
if [[ "${raw_JSON}" =~ ^(200|201|202|204)$ ]]
then
raw_JSON=$("${curl_path}" -s -H "Authorization: Bearer ${bearer_token}" "${jamf_pro_url}/api/v2/computer-groups/smart-groups")
# Collect all group data
page=0
page_size=100
total_count=0

# Get first page to determine total count
echo "$(date '+%Y-%m-%d %H:%M:%S') INFO: Fetching page ${page} of Smart Computer Groups" >> "${log_file}"
page_response=$("${curl_path}" -s -H "Authorization: Bearer ${bearer_token}" "${jamf_pro_url}/api/v2/computer-groups/smart-groups?page=${page}&page-size=${page_size}&sort=name:asc")

# Extract total count
total_count=$(echo "${page_response}" | grep -o '"totalCount"[[:space:]]*:[[:space:]]*[0-9]*' | grep -o '[0-9]*')

# Store the full first page response
raw_JSON="${page_response}"

# If there are more than 100 entries, we need to fetch additional pages and merge results
if [[ ${total_count} -gt ${page_size} ]]; then
echo "$(date '+%Y-%m-%d %H:%M:%S') INFO: Found ${total_count} total groups, fetching all pages" >> "${log_file}"

# Calculate total pages needed
total_pages=$(( (total_count + page_size - 1) / page_size ))

# Create a temporary file to collect all results
temp_file=$(mktemp)

# Extract names from first page
echo "${page_response}" | grep '"name"[[:space:]]*:' | sed 's/.*"name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' > "${temp_file}"

# Loop through remaining pages and collect names
for (( page=1; page<total_pages; page++ )); do
echo "$(date '+%Y-%m-%d %H:%M:%S') INFO: Fetching page ${page} of Smart Computer Groups" >> "${log_file}"
page_response=$("${curl_path}" -s -H "Authorization: Bearer ${bearer_token}" "${jamf_pro_url}/api/v2/computer-groups/smart-groups?page=${page}&page-size=${page_size}&sort=name:asc")

# Extract and append names from this page
echo "${page_response}" | grep '"name"[[:space:]]*:' | sed 's/.*"name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/' >> "${temp_file}"
done

# Read all group names from temp file
smart_group_names=$(cat "${temp_file}")
rm "${temp_file}"
else
# Single page, extract names directly
smart_group_names=$(echo "${raw_JSON}" | grep '"name"[[:space:]]*:' | sed 's/.*"name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/')
fi
else
# If not, present an error message
error_prompt
fi
# Convert JSON to XML plist for xpath parsing
plist_data=$(echo "${raw_JSON}" | "${plutil_path}" -convert xml1 -o - - 2>/dev/null)
# Check if plist contains data
if [[ -z "${plist_data}" ]]
then
echo "$(date '+%Y-%m-%d %H:%M:%S') ERROR: Failed to convert JSON to plist" >> "${log_file}"
# If not, present an error message
error_prompt
fi

# Extract Smart Computer Group names
smart_group_names=$(echo "${plist_data}" | xpath -q -e "//key[text()='name']/following-sibling::string[1]/text()")

# Check if we extracted group names successfully
if [[ -z "${smart_group_names}" ]]
then
echo "$(date '+%Y-%m-%d %H:%M:%S') ERROR: No Smart Computer Groups found" >> "${log_file}"
Expand Down