CI job to run ts type-check on PRs that modify beaker-vue/beaker-ts source. CI Job for beaker_kernel python tests
#142
Conversation
|
Converting to non-draft PR to test ci job. Edit: check passed, testing done. Will check feedback and we could add to project 👌🏼 |
ccjoel
changed the title
type-check on PRs that modify beaker-vue source code.
…e of a beaker-ts file to test/trigger ci job for testing.
ccjoel
changed the title
type-check on PRs that modify beaker-vue source code.type-check on PRs that modify beaker-vue/beaker-ts source. CI Job for beaker_kernel python tests
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { ref, shallowRef, computed, inject, getCurrentInstance, onBeforeMount, onBeforeUnmount, nextTick } from "vue"; |
| const lintAnnotations = ref<{}[]>([]); | ||
| const emit = defineEmits([ |
There was a problem hiding this comment.
emit constant unused (lint fix)
| run: pip install hatch | ||
|
|
||
| - name: Run tests | ||
| run: hatch run test |
There was a problem hiding this comment.
hatch run test is different than hatch test, in that it runs the [tool.hatch.envs.default.scripts] test script, which uses pytest, which we configured. hatch test uses the hatch runner with its own config (I think it potentially would try to capture more tests than whatever we configure under the test script section in pyproject.toml).
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.10' |
There was a problem hiding this comment.
We can create a matrix to test both in 3.10 and 3.11, but for now I considered that unnecessary (not many tests yet, anyways)
|
I added a github workflow job for python tests- we may not want to enable it yet. Enabled for now. There's an ~"enabled" or Under https://github.com/pricing/calculator , as an example: 
|
Updated to include 2 jobs:
Left a comment on the PR on potentially not enabling the python tests yet, for our consideration.