-
Notifications
You must be signed in to change notification settings - Fork 4
CI job to run ts type-check on PRs that modify beaker-vue/beaker-ts source. CI Job for beaker_kernel python tests
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
d039ab4
1f145fa
7595e4e
076d461
dee4fcb
b7bc152
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| --- | ||
| name: Beaker ts/vue | ||
|
|
||
| # yamllint disable-line rule:truthy | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'beaker-vue/src/**' | ||
| - 'beaker-ts/src/**' | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| jobs: | ||
| type-check: | ||
| name: Run Typescript Check | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' | ||
| cache: 'npm' | ||
| cache-dependency-path: | | ||
| beaker-ts/package-lock.json | ||
| beaker-vue/package-lock.json | ||
|
|
||
| - name: Install and build beaker-ts | ||
| working-directory: beaker-ts | ||
| shell: bash | ||
| run: | | ||
| npm ci | ||
| npm run build | ||
|
|
||
| - name: Run beaker-ts type check | ||
| working-directory: beaker-ts | ||
| shell: bash | ||
| run: tsc --noEmit --strict | ||
|
|
||
| - name: Install dependencies for beaker-vue | ||
| working-directory: beaker-vue | ||
| shell: bash | ||
| run: npm ci | ||
|
|
||
| - name: Run beaker-vue type check | ||
| working-directory: beaker-vue | ||
| shell: bash | ||
| run: npm run type-check |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| --- | ||
| name: Beaker Kernel | ||
|
|
||
| # yamllint disable-line rule:truthy | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'beaker_kernel/lib/**' | ||
| - 'tests/**' | ||
| - 'pyproject.toml' | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Run Python Tests | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.10' | ||
|
|
||
| - name: Cache pip dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.cache/pip | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('pyproject.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-pip- | ||
| - name: Install hatch | ||
| run: pip install hatch | ||
|
|
||
| - name: Run tests | ||
| run: hatch run test | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,4 +118,4 @@ export class BeakerRenderer { | |
| } | ||
|
|
||
| private _renderers: {[key: string]: IMimeRenderer}; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ | |
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { ref, shallowRef, computed, inject, getCurrentInstance, onBeforeMount, onBeforeUnmount, nextTick } from "vue"; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused (lint fix) |
||
| import { ref, computed, inject, getCurrentInstance, onBeforeMount, onBeforeUnmount, nextTick } from "vue"; | ||
| import CodeCellOutput from "./BeakerCodeCellOutput.vue"; | ||
| import Badge from 'primevue/badge'; | ||
| import Button from 'primevue/button'; | ||
|
|
@@ -88,7 +88,7 @@ const instance = getCurrentInstance(); | |
|
|
||
| const lintAnnotations = ref<{}[]>([]); | ||
|
|
||
| const emit = defineEmits([ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| defineEmits([ | ||
| 'blur', | ||
| ]) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create a matrix to test both in 3.10 and 3.11, but for now I considered that unnecessary (not many tests yet, anyways)