Skip to content

Enabled empty responses#9

Closed
tsndr wants to merge 1 commit intojhs:masterfrom
tsndr:master
Closed

Enabled empty responses#9
tsndr wants to merge 1 commit intojhs:masterfrom
tsndr:master

Conversation

@tsndr
Copy link

@tsndr tsndr commented Jul 25, 2018

If a zone exists but no records was set, it will always respond the SOA record, which is (compared to bind) the wrong behaviour. So i would push this answer instead:

res.answer.push({ name: question.name, type: question.type, data: null });

With my changes it's possible to return an empty response if the data attribute is set to null.
I hope its helpful 😊

@fogs
Copy link

fogs commented Jul 27, 2018

Hi tsndr,

It is helpful.

Please keep in mind that the DNS protocol has a special flag (NXDOMAIN) that must be set for empty responses.

I have had the same issue 2 years ago, see #5 but this project is not maintained any more.

Cheers, fogs

@tsndr
Copy link
Author

tsndr commented Jul 27, 2018

Hi fogs,

thanks for the answer 😊

What do you think about a nodejs bade dns server in general? Only for testing or production ready? And what about the performance compared to bind, could it ever hold up?

Cheers,
Tobi 😊

@fogs
Copy link

fogs commented Jul 27, 2018

If you are interested in availability, scalability, security, then choose one of the big and mature servers. PowerDNS rocks. If you like to play with the protocol, use it for stuff it was never intended to and don't think it hurts to learn more about DNS, there is no better way than building your own. We did both.

Cheers mate!

@fogs
Copy link

fogs commented Jul 27, 2018

Ach. Und Grüße nach Remagen.

@tsndr
Copy link
Author

tsndr commented Jul 27, 2018

I've never heard of PowerDNS, I might look into that 😊
I am using bind right now, but maybe I'll switch, we'll see 😉

Viele Grüße nach Hamburg 😊

@tsndr tsndr closed this Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants