Skip to content

Enabled empty responses #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsndr wants to merge 1 commit into from
Closed

Enabled empty responses #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions encode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ State.prototype.record = function(section_name, record) {

// Write the rdata. Update the position now (the rdata length value) in case self.encode() runs.
var match, rdata
if(record.data === null)
return
switch (record.class + ' ' + record.type) {
case 'IN A':
rdata = record.data || ''
Expand Down
2 changes: 1 addition & 1 deletion message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ DNSMessage.prototype.toBinary = function() {

msg[section] = msg[section] || []
msg[section].forEach(function(record) {
if(record.class != 'IN')
if(record.class != 'IN' || record.data === null)
return

// Make sure records promising data have data.
Expand Down