feat: accept pool name as positional arg in browser-pools create #110
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
kernel browser-pools create my-poolas shorthand forkernel browser-pools create --name my-pool. The--nameflag still works for backward compatibility. added this because I forget to add--nameTesting
Previously we created the pool and ignored the passed name
Now we are creating the pool and the name is set.
--namestill worksNote
Low Risk
Small CLI parsing change limited to
browser-pools create; low blast radius aside from potential behavior change when both--nameand a positional name are supplied.Overview
kernel browser-pools createnow accepts an optional positional[name]argument as a shorthand for--name.The command enforces mutual exclusivity between the positional name and
--name(returns an error if both are provided) and updates the Cobra command usage/arg validation accordingly.Written by Cursor Bugbot for commit 46881b1. This will update automatically on new commits. Configure here.