Skip to content

feat: accept pool name as positional arg in browser-pools create #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnsardesai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: accept pool name as positional arg in browser-pools create #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd224da
feat: accept pool name as positional arg in browser-pools create
tnsardesai Feb 11, 2026
46881b1
fix: error when pool name is passed both as arg and --name flag
tnsardesai Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/browser_pools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,9 @@ var browserPoolsListCmd = &cobra.Command{
}

var browserPoolsCreateCmd = &cobra.Command{
Use: "create",
Use: "create [name]",
Short: "Create a new browser pool",
Args: cobra.MaximumNArgs(1),
RunE: runBrowserPoolsCreate,
}

Expand Down Expand Up @@ -518,6 +519,12 @@ func runBrowserPoolsCreate(cmd *cobra.Command, args []string) error {
client := getKernelClient(cmd)

name, _ := cmd.Flags().GetString("name")
if len(args) > 0 && args[0] != "" {
if cmd.Flags().Changed("name") {
return fmt.Errorf("cannot specify pool name as both a positional argument and --name flag")
}
name = args[0]
}
size, _ := cmd.Flags().GetInt64("size")
fillRate, _ := cmd.Flags().GetInt64("fill-rate")
timeout, _ := cmd.Flags().GetInt64("timeout")
Expand Down