Open any url not assigned to a container in the default container#63
Merged
kintesh merged 3 commits intokintesh:masterfrom Jul 8, 2019
Nepherte:master
Merged
Open any url not assigned to a container in the default container#63kintesh merged 3 commits intokintesh:masterfrom Nepherte:master
kintesh merged 3 commits intokintesh:masterfrom
Nepherte:master
Conversation
Author
|
Also related to #10. |
|
Thanks @Nepherte, I've checked out your PR and I'm the happiest Container user ever! Since @kintesh is not responsive, and due to the fact he seem to ignore his users' honest requests as for this small but significant behavior change, very much like in #20, I think you should fork this addon and publish it at Mozilla's addon gallery by your self. I'd would have done so my self but I think the honor should be yours. |
|
Thanks @kintesh , I'm sorry I've doubted your concern to your users. I can't wait to see a new release and stop use my personal fork. Thanks a lot for creating this extension in the first place :). |
Owner
|
Sorry dude. I had to find some time been very busy moving home and stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change only keeps urls explicitly assigned to a container into that container. Urls not assigned to a container will be opened into the default one (ie. 'No Container'). As such, assigning urls to 'No Container' no longer makes sense and has been removed.