Skip to content

Convert enabled/disabled sensors to binary_sensor type #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmaertin merged 2 commits into from
Mar 15, 2026
Merged

Convert enabled/disabled sensors to binary_sensor type #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5b24e
Convert enabled/disabled sensors to binary_sensor type
ronaldvdmeer Mar 15, 2026
ab0c17c
Update tests for binary_sensor type conversion
ronaldvdmeer Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/pooldose/mappings/model_PDPR1H1HAW100_FW539187.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@
},
"circulation_pump_status": {
"key": "w_1eo2fpohe",
"type": "sensor",
"type": "binary_sensor",
"conversion": {
"|PDPR1H1HAW100_FW539187_LABEL_w_1eo2fpohe_DISABLED_|": "disabled",
"|PDPR1H1HAW100_FW539187_LABEL_w_1eo2fpohe_ENABLED|": "enabled"
"|PDPR1H1HAW100_FW539187_LABEL_w_1eo2fpohe_DISABLED_|": false,
"|PDPR1H1HAW100_FW539187_LABEL_w_1eo2fpohe_ENABLED|": true
}
},
"peristaltic_cl_dosing": {
Expand Down Expand Up @@ -247,18 +247,18 @@
},
"power_on_delay_status": {
"key": "w_1fhb0hqu2",
"type": "sensor",
"type": "binary_sensor",
"conversion": {
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0hqu2_DISABLE|": "disabled",
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0hqu2_ENABLE|": "enabled"
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0hqu2_DISABLE|": false,
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0hqu2_ENABLE|": true
}
},
"flow_delay_status": {
"key": "w_1fhb0ht7t",
"type": "sensor",
"type": "binary_sensor",
"conversion": {
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0ht7t_DISABLE|": "disabled",
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0ht7t_ENABLE|": "enabled"
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0ht7t_DISABLE|": false,
"|PDPR1H1HAW100_FW539187_LABEL_w_1fhb0ht7t_ENABLE|": true
}
},
"time_off_ph_dosing": {
Expand Down
10 changes: 5 additions & 5 deletions tests/test_mapping_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ async def test_total_entity_count(self, mapping):
async def test_entity_type_counts(self, mapping):
"""Test entity count per type."""
types = mapping.available_types()
assert len(types.get("sensor", [])) == 22
assert len(types.get("binary_sensor", [])) == 20
assert len(types.get("sensor", [])) == 19
assert len(types.get("binary_sensor", [])) == 23
assert len(types.get("number", [])) == 8
assert len(types.get("switch", [])) == 3
assert len(types.get("select", [])) == 1
Expand All @@ -107,6 +107,9 @@ async def test_new_alarm_binary_sensors(self, mapping):
"alarm_cl_too_high_orp",
"alarm_cl_too_high",
"alarm_system_standby",
"circulation_pump_status",
"power_on_delay_status",
"flow_delay_status",
]
for alarm in expected_alarms:
assert alarm in types["binary_sensor"], f"Missing binary_sensor: {alarm}"
Expand All @@ -115,12 +118,9 @@ async def test_new_sensors_with_conversions(self, mapping):
"""Test new sensors with conversion dictionaries."""
sensors = mapping.available_sensors()
sensors_with_conversion = [
"circulation_pump_status",
"peristaltic_cl_dosing",
"device_config",
"temperature_unit",
"power_on_delay_status",
"flow_delay_status",
]
for name in sensors_with_conversion:
assert name in sensors, f"Missing sensor: {name}"
Expand Down
Loading