Skip to content

Convert enabled/disabled sensors to binary_sensor type#27

Merged
lmaertin merged 2 commits intolmaertin:mainfrom
ronaldvdmeer:fix/enable-disable-to-binary-sensor
Mar 15, 2026
Merged

Convert enabled/disabled sensors to binary_sensor type#27
lmaertin merged 2 commits intolmaertin:mainfrom
ronaldvdmeer:fix/enable-disable-to-binary-sensor

Conversation

@ronaldvdmeer
Copy link
Contributor

Convert circulation_pump_status, power_on_delay_status, and flow_delay_status from sensor type with string conversion (disabled/enabled) to binary_sensor type with boolean conversion (false/true).

This aligns with Home Assistant's entity model where on/off states should be represented as binary sensors rather than enum sensors.

Changes

  • model_PDPR1H1HAW100_FW539187.json: Changed type from sensor to binary_sensor and conversion values from "disabled"/"enabled" to false/true for:
    • circulation_pump_status
    • power_on_delay_status
    • flow_delay_status

CLI output for cross-check

Binary_Sensor:
  pump_alarm: False
  ph_level_alarm: False
  orp_level_alarm: False
  flow_rate_alarm: False
  relay_alarm: True
  relay_aux1: False
  relay_aux2: False
  alarm_ofa_ph: False
  alarm_ofa_orp: False
  alarm_ofa2_ph: False
  alarm_ofa2_orp: False
  alarm_ofa2_cl: False
  alarm_water_too_cold: True
  alarm_water_too_hot: False
  alarm_ph_too_low: False
  alarm_ph_too_high: False
  alarm_cl_too_low_orp: False
  alarm_cl_too_high_orp: False
  alarm_cl_too_high: False
  alarm_system_standby: False
  circulation_pump_status: False    <-- was sensor with 'disabled'
  power_on_delay_status: False      <-- was sensor with 'disabled'
  flow_delay_status: False          <-- was sensor with 'disabled'

Change circulation_pump_status, power_on_delay_status, and flow_delay_status
from sensor type with string conversion (disabled/enabled) to binary_sensor
type with boolean conversion (false/true).

This aligns with Home Assistant's entity model where on/off states should
be represented as binary sensors rather than enum sensors.
@lmaertin lmaertin merged commit 2ba560d into lmaertin:main Mar 15, 2026
9 checks passed
@lmaertin
Copy link
Owner

well done, blazing fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants