Fix Pulse and update Henry to work with recent Looker system_activity model changes#57
Open
JorickvdHoeven wants to merge 3 commits intolooker-open-source:masterfrom
Conversation
added 3 commits
October 19, 2022 09:19
This adds typing hings to the cli.py file to allow us to leverage mypy analysis of the file and identify any type errors.
The pulse command was using outdated 3.0 API calls to Looker and the try_connection sdk command is broken in the Looker 4.0 sdk so we need to catch the exception. This also updates the queries to run with the latest Looker back end model and using the system_activity explores instead of the i__looker explore.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Henry has been having two large issues making it difficult to use:
These two problems impact Henry's ability to run and make it difficult to use. We need to fix these so that people can continue to use Henry to administer their Looker instances.
Proposed solution
Pulse command not working:
Analyze queries not working: