[2/6] Fix transposition table with proper bounds#32
Open
luccabb wants to merge 9 commits intofeature/psqt-evaluation-performancefrom
Open
[2/6] Fix transposition table with proper bounds#32luccabb wants to merge 9 commits intofeature/psqt-evaluation-performancefrom
luccabb wants to merge 9 commits intofeature/psqt-evaluation-performancefrom
Conversation
bb2ac9f to
f833c45
Compare
bca3f3e to
d7df55a
Compare
f833c45 to
7a14812
Compare
d7df55a to
e21928a
Compare
Implements correct transposition table behavior with bound types: **Transposition Table Changes:** - Add `Bound` enum: EXACT, LOWER_BOUND, UPPER_BOUND - Use Zobrist hash as cache key (fast integer vs slow FEN string) - Store bound type and depth with each cache entry - Only use cached scores when depth is sufficient - Properly handle bound types in lookups: - EXACT: use score directly - LOWER_BOUND: use if score >= beta (fail high) - UPPER_BOUND: use if score <= alpha (fail low) **Null Move Pruning Fix:** - Added missing `null_move` parameter check (was always trying null move) **Parallel Engine Updates:** - Update lazy_smp, l1p, l2p to use new zobrist hash cache key - Add context managers for Pool/Manager (proper resource cleanup) - Fix score negation in l1p (opponent perspective -> our perspective) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4f7fad5 to
1c7b8d9
Compare
This adds a chess reinforcement learning environment following the OpenEnv interface pattern, with both local and HTTP client-server modes. Features: - ChessEnvironment class with configurable rewards, opponents, and game limits - FastAPI server with REST endpoints (/reset, /step, /state, /engine-move) - HTTP client for remote environment access - Web UI for playing against the engine - HuggingFace Spaces deployment configuration (Dockerfile, openenv.yaml) - Example training scripts for local and remote usage Also includes: - mypy configuration for optional RL dependencies - Import formatting fixes for ufmt compliance
* Add OpenEnv-compatible RL environment with HuggingFace Space This adds a chess reinforcement learning environment following the OpenEnv interface pattern, with both local and HTTP client-server modes. Features: - ChessEnvironment class with configurable rewards, opponents, and game limits - FastAPI server with REST endpoints (/reset, /step, /state, /engine-move) - HTTP client for remote environment access - Web UI for playing against the engine - HuggingFace Spaces deployment configuration (Dockerfile, openenv.yaml) - Example training scripts for local and remote usage Also includes: - mypy configuration for optional RL dependencies - Import formatting fixes for ufmt compliance * Remove Elo claim and fix GitHub link to open in new tab
Fixes: - Remove incorrect `bash .env` line (was trying to execute .env as script) - Add `set -e` to exit on errors - Check if brew is installed before using it - Check if git-lfs/envsubst already installed before reinstalling - Validate build succeeded before continuing - Verify dist/moonfish exists before copying - Check if lichess-bot directory exists - Validate LICHESS_TOKEN is set after sourcing .env - Validate token is not empty when creating .env - Use `cp -f` instead of rm + cp Improvements: - Make lichess-bot directory configurable via LICHESS_BOT_DIR env var - Add progress messages for better UX - Provide helpful error messages with next steps Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Add Stockfish benchmark CI workflow - Runs cutechess-cli matches against Stockfish on every PR - 20 rounds with max concurrency - Moonfish: 60s per move, Stockfish: Skill Level 5 with 60+5 time control - Downloads full 170MB opening book from release assets (bypasses LFS) - Reports win/loss/draw stats in GitHub job summary - Uploads PGN and logs as artifacts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Parallelize Stockfish benchmark with matrix strategy - Run 20 parallel jobs (10 chunks × 2 skill levels) - Test against both Stockfish skill level 4 and 5 - 100 games per skill level = 200 total games for reliable signal - Add aggregation job to combine results with summary table - Use different random seeds per chunk for opening variety * Add PR comment with benchmark results - Post aggregated results as a comment on the PR - Makes it easy to see win/loss/draw rates without navigating to CI - Includes collapsible configuration details * Add -repeat flag for more consistent benchmark results - Each opening is played twice with colors reversed - Eliminates first-move advantage variance - Doubles games to 400 total (200 per skill level) - More statistically reliable results between runs * Add detailed stats to benchmark PR comment - Show win rates by color (as White / as Black) - Show loss reasons (timeout, checkmate, adjudication) - Separate tables per skill level for clarity * Fix termination parsing and correct game count - Parse game endings from PGN move text (cutechess format) - Track: checkmate, timeout, resignation, stalemate, repetition, 50-move - Fix config: 200 total games (not 400) * Simplify game endings - parse merged PGN directly - Remove per-chunk termination tracking - Parse game endings from merged PGN in aggregate step - Cleaner and less error-prone * Extract game endings dynamically from PGN text * Filter out mates from game endings (redundant with win/loss) * Rename to 'Non-checkmate endings' * Add skill level 3 and skip aggregate if all jobs cancelled - Test against Stockfish skill levels 3, 4, and 5 (300 total games) - Only run aggregate job if at least one benchmark succeeded * Hardcode concurrency to 10 for faster benchmarks * Increase to 20 rounds and 20 concurrency (600 total games) * Reduce to 5 chunks (15 total jobs, 300 games) * Add PR reactions: eyes on start, thumbs up on complete - React with 👀 when benchmark starts - React with 👍 after results are posted * Add local benchmark script * Add skill level 1, increase to 200 games per level (800 total) * Revert CI changes, update local script: skill level 1, 200 games/level * Add skill level 2 to local benchmark script * Update benchmark settings - Local script: 100 rounds, 15 concurrency - CI: Remove eyes reaction when adding thumbs up --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* Only run benchmarks when engine code changes * Remove lichess from path filter (not engine code) * Run benchmarks on PRs to any branch, not just master
🔬 Stockfish Benchmark Resultsvs Stockfish Skill Level 3
Non-checkmate endings:
vs Stockfish Skill Level 4
Non-checkmate endings:
vs Stockfish Skill Level 5
Non-checkmate endings:
Configuration
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boundenum (EXACT, LOWER_BOUND, UPPER_BOUND) for correct TT behaviornull_moveparameter check)Details
The transposition table now correctly stores and uses bound information:
This prevents incorrect cutoffs and score usage that can cause search instability.
Parallel Engine Updates
All parallel engines (lazy_smp, l1p, l2p) updated to:
Test plan
🤖 Generated with Claude Code