Skip to content

added social logos for github and X#183

Merged
robertodauria merged 4 commits intom-lab:mainfrom
Recxsmacx:Social
Mar 4, 2026
Merged

added social logos for github and X#183
robertodauria merged 4 commits intom-lab:mainfrom
Recxsmacx:Social

Conversation

@Recxsmacx
Copy link
Contributor

@Recxsmacx Recxsmacx commented Feb 28, 2026

fixes #170

image

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things left - I commented on them inline.

In case you're using AI for these changes, please remember disclosure is mandatory.

@Recxsmacx
Copy link
Contributor Author

A few things left - I commented on them inline.

In case you're using AI for these changes, please remember disclosure is mandatory.

@robertodauria will take care of every line of code pushed from my side will double check it every time.

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks.

@robertodauria will take care of every line of code pushed from my side will double check it every time.

I appreciate that, but we still require AI usage disclosure on every PR in addition to normal due diligence. I don't understand from your answer if you're saying AI was not used, or it was used but you're being careful. If it's the latter, it still needs to be disclosed.

Remove text decoration and border from social icon links.
@robertodauria
Copy link
Contributor

I appreciate that, but we still require AI usage disclosure on every PR in addition to normal due diligence. I don't understand from your answer if you're saying AI was not used, or it was used but you're being careful. If it's the latter, it still needs to be disclosed.

@Recxsmacx ping on this :)

@Recxsmacx
Copy link
Contributor Author

No ai is used in it ,

I appreciate that, but we still require AI usage disclosure on every PR in addition to normal due diligence. I don't understand from your answer if you're saying AI was not used, or it was used but you're being careful. If it's the latter, it still needs to be disclosed.

@Recxsmacx ping on this :)

Sorry for replying late no ai is used in it !! , I'll make sure I'll mark the disclosure yes or no

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@robertodauria robertodauria merged commit e51de54 into m-lab:main Mar 4, 2026
2 checks passed
@Recxsmacx
Copy link
Contributor Author

Thanks @robertodauria 🫂

@Recxsmacx Recxsmacx deleted the Social branch March 4, 2026 15:13
@Recxsmacx
Copy link
Contributor Author

@robertodauria hey !! Hope you're doing good as most of the contributors left because of gsoc .... The projects which were planned for gsoc I want to work on them , I want the mentorship and guidance which you guys were offering earlier. And I'm not able to find the group working so requesting you to guide me to the way through this thanks 🕊️

Project:- the ui enhancement of speedtest website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respective Icons can be placed with the socials

2 participants