chore(assert): add experiment to assert if Recipe labels are set#145
Open
niladrih wants to merge 1 commit intomayadata-io:masterfrom
Open
chore(assert): add experiment to assert if Recipe labels are set#145niladrih wants to merge 1 commit intomayadata-io:masterfrom
niladrih wants to merge 1 commit intomayadata-io:masterfrom
Conversation
Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
| name: assert-labels-set-as-Completed-after-reconciliation | ||
| namespace: d-testing | ||
| labels: | ||
| d-testing.dope.mayadata.io/inference: "true" |
There was a problem hiding this comment.
inference.yaml needs to be modified since new experiments have been added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change?
I have added an experiment with 4 Recipes. 2 of them are helpers. The remaining 2 are primary Recipes.
The first helper Recipe will reach 'Completed' state after being created.
The second helper Recipe will reach 'Error' state after being created.
The primary Recipes will assert if the correct labels were set on to the helper Recipes after reconciliation.
The first primary Recipe will assert if the labels are set on to the first helper.
The second primary Recipe will assert if the labels are set on to the second helper.
Signed-off-by: Niladri Halder niladri.halder@mayadata.io