optimize: mv deploy/stop script #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the deployment and stop scripts by introducing absolute path references, allowing the scripts to be executed from any directory. The key changes include script directory auto-detection and converting all relative paths to absolute paths based on the detected project root.
- Adds
PROJECT_ROOTvariable detection in all scripts to calculate the project root directory - Updates all file paths (logs, service directories) to use absolute paths via
$PROJECT_ROOTor%PROJECT_ROOT% - Changes batch file comment style from
::toREMfor consistency - Adds comprehensive README.md documentation for the scripts directory
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/stop.sh | Adds PROJECT_ROOT detection and converts PID file paths to absolute paths |
| scripts/stop.bat | Changes comment style from :: to REM |
| scripts/deploy.sh | Adds PROJECT_ROOT detection and converts all directory navigation and log file paths to absolute paths |
| scripts/deploy.bat | Adds PROJECT_ROOT detection and updates cd commands to use absolute paths |
| scripts/README.md | New documentation file explaining script usage, troubleshooting, and the path variable system |
Comments suppressed due to low confidence (1)
scripts/deploy.bat:5
- The PROJECT_ROOT detection is incorrect. Using 'cd' gets the current working directory where the script is called from, not the script's directory. This defeats the purpose of the optimization. Consider using '%~dp0' to get the script's directory and then navigate to the parent:
set "SCRIPT_DIR=%~dp0"followed byfor %%A in ("%SCRIPT_DIR%..") do set "PROJECT_ROOT=%%~fA".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+55
| cd /path/to/lifetcontext | ||
| ./scripts/deploy.sh | ||
| ``` | ||
|
|
||
| **停止所有服务：** | ||
| ```bash | ||
| cd /path/to/lifetcontext |
There was a problem hiding this comment.
Corrected spelling of 'lifetcontext' to 'lifecontext'.
Suggested change
| cd /path/to/lifetcontext | |
| ./scripts/deploy.sh | |
| ``` | |
| **停止所有服务：** | |
| ```bash | |
| cd /path/to/lifetcontext | |
| cd /path/to/lifecontext | |
| ./scripts/deploy.sh |
停止所有服务：
cd /path/to/lifecontext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.