Conversation
jankapunkt
reviewed
Nov 28, 2023
packages/blaze-tools/tojs.js
Outdated
| if (attrs) { | ||
| attrsArray = []; | ||
| var needsHTMLAttrs = false; | ||
| let needsHTMLAttrs = false; |
Collaborator
There was a problem hiding this comment.
needsHTMLAttrs is not defined in the tests. I assume this is a scoping issue and previously needsHTMLAttrs was simply wrong scoped and used outside it's defined scope and since it was a var this was possible.
I think this whole block of loops need some more refactoring effort. Maybe we can split it into several methods to better handle scoping?
Collaborator
Author
There was a problem hiding this comment.
Agreed, I was going just for the minimum reproduction to move things forward one step at a time.
This was referenced Dec 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies of
blaze-toolMigrate old
vars toletandconst.Simplified version (so far) of #397
#397 had also some additional changes which I'm not that certain about.