MMDevice: remove 3 Camera functions (bumps DIV)#860
Open
marktsuchida wants to merge 1 commit intomicro-manager:mainfrom
Open
MMDevice: remove 3 Camera functions (bumps DIV)#860marktsuchida wants to merge 1 commit intomicro-manager:mainfrom
marktsuchida wants to merge 1 commit intomicro-manager:mainfrom
Conversation
These have already been made `final` recently to prevent override. GetPixelSizeUm() - never called from Core, intent unclear GetComponentName() - never called from Core, inconsistent impls PrepareSequenceAcqusition() - inconsistent impls, seldom of value, typo in name
Member
Author
|
This will be merged as part of #861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #596
Closes #754
Closes #595
These have already been made
finalrecently to prevent override.GetPixelSizeUm()- never called from Core, intent unclearGetComponentName()- never called from Core, inconsistent implsPrepareSequenceAcqusition()- inconsistent impls, seldom of value, typo in name