Super-PR for Device Interface Version 75#861
Open
marktsuchida wants to merge 16 commits intomicro-manager:mainfrom
Open
Super-PR for Device Interface Version 75#861marktsuchida wants to merge 16 commits intomicro-manager:mainfrom
marktsuchida wants to merge 16 commits intomicro-manager:mainfrom
Conversation
let them signal whether they use callbacks to update the UI about their position.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
isXYStageUsingCallbacks functions. Bump MMCore version to 11.12.0.
functions in DeviceAdapters that use the OnStage (and OnXYStage) PosityionChanged callbacks. I did not fully check all device adapters to make sure they use the callbacks all the time, nevertheless, this seems a good start.
should always return the same value as the UI will not query these functions continuously.
unless completely confident they actually do (ZeissCAN29, DemoCamera, Cephla)
This change is safe, in the sense that it won't cause any silent change
in overload resolution.
In the unlikely event that a camera adapter (that we don't control)
calls InsertImage(c, b, w, h, bpp, 0), which previously resolved to the
single-component overload (0 being null serializedMetadata), it would
now get a compiler error ("call is ambiguous"). Such calls would need to
remove the 0 or replace it with `nullptr`.
These have already been made `final` recently to prevent override. GetPixelSizeUm() - never called from Core, intent unclear GetComponentName() - never called from Core, inconsistent impls PrepareSequenceAcqusition() - inconsistent impls, seldom of value, typo in name
Resolved MMCore version to 11.14.0 (main had 11.13.0).
…ss' and 'mmdevice-remove-3-camera-funcs' into div-75
Member
|
Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #847
Closes #642
Merging this merges #808, #859, and #860.