Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026

❔What, Why & How

PushChanges only returned a value on the PR creation path, leaving $prUrl null for direct commits. This resulted in misleading output: "PR URL: " with no value.

Changes:

  • Return empty string when DirectCommit is true
  • Conditionally display PR URL in notice message only when non-empty
# Before
Write-Host "::notice::Deployed to $repo branch $branch. PR URL: $prUrl"
# Output for direct commits: "Deployed to repo branch main. PR URL: "

# After
if ($prUrl) {
    Write-Host "::notice::Deployed to $repo branch $branch. PR URL: $prUrl"
} else {
    Write-Host "::notice::Deployed to $repo branch $branch"
}
# Output for direct commits: "Deployed to repo branch main"

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…notice message

Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix minor issues in e2e tests and deployment Fix PushChanges return value handling for direct commits Jan 21, 2026
Copilot AI requested a review from mazhelez January 21, 2026 22:06
@mazhelez mazhelez marked this pull request as ready for review January 21, 2026 22:30
@mazhelez mazhelez requested a review from a team as a code owner January 21, 2026 22:30
@mazhelez mazhelez merged commit 3b3358f into mazhelez/rerun-workflows-e2etests Jan 21, 2026
1 check passed
@mazhelez mazhelez deleted the copilot/sub-pr-2092 branch January 22, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants