Skip to content

Fix PushChanges return value handling for direct commits #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mazhelez merged 2 commits into from
Jan 21, 2026
Merged

Fix PushChanges return value handling for direct commits #2093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be09114
Initial plan
Copilot Jan 21, 2026
8ebf3ba
Fix PushChanges to return empty string for direct commits and update …
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Internal/Deploy.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function PushChanges
# Direct commit to base branch
invoke-git commit --allow-empty -m $CommitMessage
invoke-git push origin $BaseBranch
return ""
} else {
# Create PR to base branch
if (-not (git ls-remote --heads origin $BaseBranch)) {
Expand Down Expand Up @@ -245,7 +246,11 @@ try {
Set-Content -Path (Join-Path "./.github" "RELEASENOTES.copy.md") -Value $releaseNotes -Encoding utf8
}
$prUrl = PushChanges -BaseBranch $branch -CommitMessage "Deploying AL-Go from $algoBranch ($srcSHA) to $branch" -DirectCommit $directCommit
Write-Host "::notice::Deployed to $repo branch $branch. PR URL: $prUrl"
if ($prUrl) {
Write-Host "::notice::Deployed to $repo branch $branch. PR URL: $prUrl"
} else {
Write-Host "::notice::Deployed to $repo branch $branch"
}
}
}
finally {
Expand Down