Skip to content

fix: update subprocess calls in script #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roopan-Microsoft merged 1 commit into from
Mar 2, 2026
Merged

fix: update subprocess calls in script #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion archive-doc-gen/scripts/auth_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def add_client_secret(credential, app_id):


def update_azd_env(name, val):
subprocess.run(f"azd env set {name} {val}", shell=True)
subprocess.run(["azd", "env", "set", name, val], shell=False, check=True)


if __name__ == "__main__":
Expand Down
30 changes: 24 additions & 6 deletions archive-doc-gen/scripts/data_preparation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,15 @@ def create_or_update_search_index(
if not admin_key:
admin_key = json.loads(
subprocess.run(
f"az search admin-key show --subscription {subscription_id} --resource-group {resource_group} --service-name {service_name}",
shell=True,
[
"az", "search", "admin-key", "show",
"--subscription", subscription_id,
"--resource-group", resource_group,
"--service-name", service_name
],
shell=False,
capture_output=True,
check=True,
).stdout
)["primaryKey"]

Expand Down Expand Up @@ -312,9 +318,15 @@ def upload_documents_to_index(
if not admin_key:
admin_key = json.loads(
subprocess.run(
f"az search admin-key show --subscription {subscription_id} --resource-group {resource_group} --service-name {service_name}",
shell=True,
[
"az", "search", "admin-key", "show",
"--subscription", subscription_id,
"--resource-group", resource_group,
"--service-name", service_name
],
shell=False,
capture_output=True,
check=True,
).stdout
)["primaryKey"]

Expand Down Expand Up @@ -349,9 +361,15 @@ def validate_index(service_name, subscription_id, resource_group, index_name):
api_version = "2024-03-01-Preview"
admin_key = json.loads(
subprocess.run(
f"az search admin-key show --subscription {subscription_id} --resource-group {resource_group} --service-name {service_name}",
shell=True,
[
"az", "search", "admin-key", "show",
"--subscription", subscription_id,
"--resource-group", resource_group,
"--service-name", service_name
],
shell=False,
capture_output=True,
check=True,
).stdout
)["primaryKey"]

Expand Down