Skip to content

Refactor: Use populateTagsMap helper for tag population in client.ts#91

Merged
torosent merged 2 commits intotorosent/add-tagsfrom
copilot/sub-pr-89-again
Feb 3, 2026
Merged

Refactor: Use populateTagsMap helper for tag population in client.ts#91
torosent merged 2 commits intotorosent/add-tagsfrom
copilot/sub-pr-89-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Addresses feedback from PR #89 to eliminate duplicate tag population logic in client.ts by using the existing populateTagsMap helper function.

Changes

  • Exported populateTagsMap from pb-helper.util.ts
  • Replaced manual Object.entries loop and conditional check in client.ts with helper function call

Example

Before:

if (tags) {
  const tagsMap = req.getTagsMap();
  for (const [key, value] of Object.entries(tags)) {
    tagsMap.set(key, value);
  }
}

After:

populateTagsMap(req.getTagsMap(), tags);

The helper already handles undefined tags gracefully, matching the pattern used in newScheduleTaskAction and newCreateSubOrchestrationAction.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 3, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • node-precompiled-binaries.grpc.io
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/durabletask-js/durabletask-js/node_modules/.bin/node-pre-gyp install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on adding tags support for activities and APIs Refactor: Use populateTagsMap helper for tag population in client.ts Feb 3, 2026
Copilot AI requested a review from torosent February 3, 2026 22:23
@torosent torosent marked this pull request as ready for review February 3, 2026 22:25
@torosent torosent merged commit 64e87dd into torosent/add-tags Feb 3, 2026
1 check passed
@torosent torosent deleted the copilot/sub-pr-89-again branch February 3, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants