Skip to content

chore: bump dockerfile to use .NET SDK 10 and drop jammy as its not supported by Microsoft anymore #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominik-niebuhr wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −65
Open

chore: bump dockerfile to use .NET SDK 10 and drop jammy as its not supported by Microsoft anymore #3276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e94a36
chore: remove support for 'jammy' flavor in Docker scripts
dominik-niebuhr Jan 28, 2026
dee1ab0
chore: update Dockerfile to use .NET SDK 10.0-noble
dominik-niebuhr Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flavor: [jammy, noble]
flavor: [noble]
runs-on: [ubuntu-24.04, ubuntu-24.04-arm]
steps:
- uses: actions/checkout@v5
Expand Down
46 changes: 0 additions & 46 deletions utils/docker/Dockerfile.jammy
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion utils/docker/Dockerfile.noble
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/dotnet/sdk:8.0-noble
FROM mcr.microsoft.com/dotnet/sdk:10.0-noble

ARG DEBIAN_FRONTEND=noninteractive
ARG TZ=America/Los_Angeles
Expand Down
2 changes: 1 addition & 1 deletion utils/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -e
set +x

if [[ ($1 == '--help') || ($1 == '-h') || ($1 == '') || ($2 == '') ]]; then
echo "usage: $(basename $0) {--arm64,--amd64} {jammy,noble} playwright:localbuild-noble"
echo "usage: $(basename $0) {--arm64,--amd64} {noble} playwright:localbuild-noble"
echo
echo "Build Playwright docker image and tag it as 'playwright:localbuild-noble'."
echo "Once image is built, you can run it with"
Expand Down
20 changes: 4 additions & 16 deletions utils/docker/publish_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ else
exit 1
fi

# Ubuntu 22.04
JAMMY_TAGS=(
"v${PW_VERSION}-jammy"
)

# Ubuntu 24.04
NOBLE_TAGS=(
Expand Down Expand Up @@ -64,12 +60,10 @@ install_oras_if_needed() {
publish_docker_images_with_arch_suffix() {
local FLAVOR="$1"
local TAGS=()
if [[ "$FLAVOR" == "jammy" ]]; then
TAGS=("${JAMMY_TAGS[@]}")
elif [[ "$FLAVOR" == "noble" ]]; then
if [[ "$FLAVOR" == "noble" ]]; then
TAGS=("${NOBLE_TAGS[@]}")
else
echo "ERROR: unknown flavor - $FLAVOR. Must be either 'jammy' or 'noble'"
echo "ERROR: unknown flavor - $FLAVOR. Must be 'noble'"
exit 1
fi
local ARCH="$2"
Expand All @@ -90,12 +84,10 @@ publish_docker_images_with_arch_suffix() {
publish_docker_manifest () {
local FLAVOR="$1"
local TAGS=()
if [[ "$FLAVOR" == "jammy" ]]; then
TAGS=("${JAMMY_TAGS[@]}")
elif [[ "$FLAVOR" == "noble" ]]; then
if [[ "$FLAVOR" == "noble" ]]; then
TAGS=("${NOBLE_TAGS[@]}")
else
echo "ERROR: unknown flavor - $FLAVOR. Must be either 'jammy' or 'noble'"
echo "ERROR: unknown flavor - $FLAVOR. Must be 'noble'"
exit 1
fi

Expand All @@ -114,10 +106,6 @@ publish_docker_manifest () {
done
}

publish_docker_images_with_arch_suffix jammy amd64
publish_docker_images_with_arch_suffix jammy arm64
publish_docker_manifest jammy amd64 arm64

publish_docker_images_with_arch_suffix noble amd64
publish_docker_images_with_arch_suffix noble arm64
publish_docker_manifest noble amd64 arm64
Loading