Skip to content

Initial implementation of translation through AWS Translation#175

Open
xoriath wants to merge 6 commits intomicrosoft:mainfrom
MicrochipTech:translate-with-aws
Open

Initial implementation of translation through AWS Translation#175
xoriath wants to merge 6 commits intomicrosoft:mainfrom
MicrochipTech:translate-with-aws

Conversation

@xoriath
Copy link

@xoriath xoriath commented Nov 8, 2024

Fully inspired by #153 , but extended to add a command for using Amazon Translate.

@TylerLeonhardt
Copy link
Member

This is super interesting and cool. Thanks for putting this together.

At this time, I don't think we can take this on because:

  • The Azure stuff is experimental so I'm still experimenting with the shape... adding another target makes that move slower
  • I don't have an AWS subscription to test this... so I worry about maintainability

In the meantime, I recommend forking this project and releasing it on NPM... at least until I have more time to revisit this stuff.

Ideally I give you a plug in model that you can just hook into

@xoriath
Copy link
Author

xoriath commented Nov 13, 2024

I can do that, if you think a fork works better for now :) And I'm also happy to follow up on any changes that you want to do to the azure model, or even help out with hooking up a plugin if that's the direction you want to take it :)

@TylerLeonhardt
Copy link
Member

For now, fork. I think we are probably a ways away from a plugin model.

@xoriath
Copy link
Author

xoriath commented Nov 13, 2024

Sounds like a plan!

@xoriath xoriath force-pushed the translate-with-aws branch from 1a82b05 to be466be Compare April 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants