Initial implementation of translation through AWS Translation#175
Open
xoriath wants to merge 6 commits intomicrosoft:mainfrom
Open
Initial implementation of translation through AWS Translation#175xoriath wants to merge 6 commits intomicrosoft:mainfrom
xoriath wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Member
|
This is super interesting and cool. Thanks for putting this together. At this time, I don't think we can take this on because:
In the meantime, I recommend forking this project and releasing it on NPM... at least until I have more time to revisit this stuff. Ideally I give you a plug in model that you can just hook into |
Author
|
I can do that, if you think a fork works better for now :) And I'm also happy to follow up on any changes that you want to do to the azure model, or even help out with hooking up a plugin if that's the direction you want to take it :) |
Member
|
For now, fork. I think we are probably a ways away from a plugin model. |
Author
|
Sounds like a plan! |
1a82b05 to
be466be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully inspired by #153 , but extended to add a command for using Amazon Translate.