Merged
Conversation
* Initial updates to handle new UX requirements * Add segment udpates * Fix class * Fix center text * rtl updates for segments * Remove rtl test * Add back padding * Fix padding and columns * Add fix for bad class * Remove comment * Update tests * Fix test * Update libs/blocks/timeline/timeline.js --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
* Fix: Setting allowedOrigins for standalone gnav * Fix: Default handling
…idual SVG assets (adobecom#3259) * updated features/icons to pull from federal and allow the icons set to be sharepoint authorable * bettter icon-spacing handling * preload federated.js instead of non used icons.svg on util decorateIcon() * Updated preload federated as script type not fetch * Minor clean up based on pr feedback * remove console * addressed some issues found w/ icons not rending in tables due to race condition w/ decorateIcon() * lana instead of console * no 100% height * coverage * full coverage * minor cleanup * minor cleanup * preload first section icons, spread syntax * no cons * Performace refactor - loadIcons to hold most related functionallity. Preloaded inView icons and defered others till postSectionLoad. * async decTooltips and refactor to not chain func calls * fix: icon alignment in georouting modal's button * move render blocking code to utils * fix import of test method * remove condition that causes error when no icon is in view * remove redundant link load * remove extra federated.js import * small change to push branch * Fed Icons - Table icon decoration and collapse icon wrapping (adobecom#3202) * reselect icons after area is decorated * fix inline margin issue in table collapse titles --------- Co-authored-by: Saugat Malla <saugat@TBXTOR-2021MBP16-SaugatMalla.local> Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Sartxi <sean.archibeque@gmail.com>
will use www.adobe.com cached calls of WCS
…ecom#3317) updating the job to manual trigger Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>
* MWPW-154147-spectrum switch * MWPW-154147-spectrum switch * MWPW-154147-spectrum switch test * MWPW-154147-spectrum switch test --------- Co-authored-by: Sonja Popovic <cod55010@adobe.com>
update tooltip locator Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@SantoshumarsMBP.attlocal.net>
…c for not signed in (adobecom#3324) * remobe personalization for signed out, change domain names for stage and prod * dummy-pr * remove hlx and aem check for getting url * A&T property check on default production * Fix decode URI at the base * Fix amcv cookie name post decode * Add Amcv encoding during setting cookie
…ecom#3201) * Fixing the issue that sidenav can't be collapsed. * Unit test update. * Move string to a const * results announce * trying to fix the unit test * role status > aria-live polite * aria-live polite test update
…3299) * Sets Auto Select for cotentType as default * Adds beta link to original bulkpublisher * Implements qa feedback and other imnprovements * ESlint errors * Implements previous PR review comments * Fixes ESLint errors --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
* MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (adobecom#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (adobecom#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (adobecom#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (adobecom#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (adobecom#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (adobecom#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (adobecom#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (adobecom#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (adobecom#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (adobecom#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (adobecom#3282) * bump to 10 seconds * new change * MWPW-161645: lana logging for CCD (adobecom#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * add build artifacts --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Ilyas Türkben <tuerkben@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Ilyas Türkben <ilyas@adobe.com>
Remove ee from the link
chore: ignore tmp
* initial publish * first commit * cleaned up * fixed id dupes * tighten up accordion height, increase width * Add source * Remove shown * Fix freshManifest source * committing better version not neat * added divs to dropdowns * stab at data parse for db * refine parseMepConfig * align to db, improve form look, add event listeners * stop using block name constant * update to aws api * Unfinished code for Viv * Fix undefined manifest * Add back properties and fix small DOM issue * Add get getMepPopup * stash * save working * Confine listeners to current meplist * add url param and hash method for sharing * just omit promos out of date range * minor fixes and checks * add condition for mepHighlight * pulling in manifest info * don't show arrow on mep panel in mmm * refactor functions * Fix radio and preview buttons * Remove comment * Fix typo * rework share logic fix spacing color * fix merge conflict bug * fix merge conflict created bug * Add another pageId * Fix label click issue * Fix pencil issue * bunch of fixes * deep link * add conditional chaining * refactor and streamline * update now that pathname is sent by db * fix page search for new db structure * switch to full field name not first letter * change all to empty * top geos and top pages * remove line * fix breaking from merge * loops through filters instead of hard code * keep share button on right in mobile * no longer using form.html * default all doesn't need to be in Word * share button on top * create shareButton listeners at creation * rename functions * remove unneeded files * restore fix to update button * change served to found * add change listener to input * unit tests working * button back but not visible * button fixed * add sharebutton unit test * fix share button test * repair existing unit tests * update mmm test after other fixes * collapse all when new one opened * update to new db column names * fix issue with preview link including entire manifest url instead of just path * fix activites filter in saveToMmm * add source for mep param, fix filter for save * fix radio buttons to only use path * duplicate schedule info * mmmremovemepsource * fix page save and analyticsTitle * tweak placeholder helpful info * Fix code scanning alert no. 235: Incomplete URL substring sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * remove unused * tweak to suggested security fix * unit test update * curious what the security check says * revert * remove authorization * lint issue * simplify milo check * add source to default promo shell... again * update css rule for add manifest input * hide scheduled info in mmm * remove unused import and return error message --------- Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…fix (adobecom#3318) * Adding dynamic-nav-group setting to allow distinction between dynamic-nav user journeys * Utils change * Ensuring status shows correctly dispite group * Making metadata case insensative * Does a check for status.js if storage item does not exist --------- Co-authored-by: Megan Thomas <methomas@adobe.com>
* cta color hover change * cta color hover change * cta color hover change --------- Co-authored-by: Suhani <suhjain@suhanis-mbp.corp.adobe.com>
Fix optional profile page detail
* MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * Trigger Build --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
…nd individual SVG assets" (adobecom#3356) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and indiv…" This reverts commit 81a5770.
* Adding video fill variant * PR feedback, css clean up * Fixing code conflicts with adobecom#3053 --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* Adds marketo forms2.min.js to dependencies, upates dependency workflow, updates marketo.js to call form from correct location * Adding comment for git change only * Adding comment to hopefully see change * Removing comments * Typo * Updating PR description * Fixing tests
…ecom#3365) Revert "MWPW-163754 Color difference is seen in the milo pages (adobecom#3330)" This reverts commit 4bbfba0.
add basic mep-actions test Co-authored-by: John Pratt <jpratt@adobe.com>
…r testing (adobecom#3147) * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * implemented cheveron up and down functionality for checkmark copy list * added isMobile check * Fix backward compatibility issues * minor * minor css fixes as per figma * refactored large "decorateFooterRows" method * remove duplicate css review comment * review comments * UT added * fix post merge conflict * npm run build * linter * UT coverage * mini compare covergae * review comment * fix post merge. margin was affected due to ul change * fixed ul after merge conflict with the other fix PR * linter * resolved conflicts * fixed mini-compare-chart footer cta alignment * decreased footer rows height to match the design * fixed mini-compare footer alignment * fixed footer horizontal padding and mobile breakpoint * updated unit tests * corrected paddings, font sizes and other * corrected slots * corrected padding * footer padding corrected * corrected heading-m-price padding --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: Mira <myrosvas@gmail.com>
* MWPW-163380 - Missing project details locui create * Added missing project details page for locui create as query params are lost after sucessfull login Resolves: https://jira.corp.adobe.com/browse/MWPW-163380 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://mwpw-163380-instructions-loc-create--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off * MWPW-163380 - Fixed some issues * Added margin zero * Fixed mock class Resolves: https://jira.corp.adobe.com/browse/MWPW-163380 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://mwpw-163380-instructions-loc-create--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off * feat: added links for respective environments * feat: changed text for goto list
Setting a scroll value to true
Adding bottom spacing Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* adding save today on ctaTextOption * Update the unit test.
…dobecom#3417) Removed lorem ipsum text check from preflight div
…m#3389) * Setting aria-live to shadowRoot element instead to the slot. * Update unit test. * Adding escape in case there is no resultText. * Moving the aria-live code to mas
* List accessibility for quiz-marquee <!-- Before submitting, please review all open PRs. --> * Update quiz-marquee authoring to denote nested lists * roles for list and listitem in quiz-marquee and quiz-results Resolves: [MWPW-165027](https://jira.corp.adobe.com/browse/165027-NUMBER) * PR feedback
* MWPW-164107: Mnemonic list fixed * ignored line * a * Revert "a" This reverts commit 9d18f6b.
* MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout (adobecom#3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place * Make mobile styles the default * Mobile Gnav Redesign for Adobe Home (adobecom#3151) * fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode * Mobile gnav breadcrumbs new design (adobecom#3155) * Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css * Fixing css for no breadcrumbs page * Adding main menu placeholder (adobecom#3157) * Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix * Keyboard navigation for mobile gnav redesign (adobecom#3158) * Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue * Localnav design and event listeners (adobecom#3164) * Localnav design and event listeners * Lint fix * Adding Overview title support * Handling CLS issue for localnav - mobile gnav redesign (adobecom#3198) * Handling CLS issue by preserving space for localnav * Adding localnav config * Adding overview text from placeholder * Adding meta data check for new mobile gnav feature flag * Lint fix * Adding localnav only when mobile gnav v2 is true * Adding image support for large menu and medium menus on gnav (adobecom#3235) * Adding image support on gnav * Decorating localnav only if it has one section * Lint fix * Fixing dropdown promise issue * Handle CLS issue on localnav: mobile redesign (adobecom#3253) * Check for localnav * Moving getGnanSource to utils * Awaiting gnav source * Adding lanalog when there is mismatch with content and name * Lint fixes * Changing height of localnav * Temp window url for testinf * Temp window url for testing * Added Analytics Attributes to Tabs and Tabpanels (adobecom#3275) * Added analytics attributes to tabs and tabpanels * Handle cases where we don't find daa attributes * [MWPW-159665] - Gnav redesign animations (adobecom#3234) * MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout (adobecom#3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place * Make mobile styles the default * Mobile Gnav Redesign for Adobe Home (adobecom#3151) * fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode * Mobile gnav breadcrumbs new design (adobecom#3155) * Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css * Fixing css for no breadcrumbs page * Adding main menu placeholder (adobecom#3157) * Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix * Keyboard navigation for mobile gnav redesign (adobecom#3158) * Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue * Localnav design and event listeners (adobecom#3164) * Localnav design and event listeners * Lint fix * Adding Overview title support * Added animations for mobile redesign * Polish animations * Polish animations * polish animations * Resolved comment --------- Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Raghav Sharma <raghavs@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> * Adding active column logic in a large menu (adobecom#3276) * Adding active column logic in a large menu * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [MWPW-159667] - Add dark mode fixes (adobecom#3285) * dark mode changes * lint-fix * small fix for animation * Fix spacing and dark mode things for localnav * Set page overlay for local nav * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation * [MWPW-163735] - Added Local Nav keyboard navigation for mobile GNAV redesign (adobecom#3321) * Added localnav keyboard navigation for mobile gnav redesign * Added fixes for Local nav along with keyboard navigation * lint fix * Gnav bugs (adobecom#3346) * Fixing mega menu CTA height * Localnav z index and removing default makeActiveTab call * Localnav z index to 9 * Fix: georouting issue * [MWPW-164088] - UT for mobile GNAV redesign (adobecom#3359) * UT for mobile GNAV redesign * lint fix * lint fix * lint fix * lint fix * Added More UT's * Making localnav auto dismiss on click outside (adobecom#3368) * Making localnav auto dismiss on click outside * making active link in localnav bold * Fix for multi level localnav click * UT fixes * Making localnav close on curtain click * Fix: String check update for localnav * Adding disable-scroll when localnav is opened * Adding scroll for tabs * Update libs/blocks/global-navigation/utilities/utilities.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Added fix for UT and bug MWPW-163859 * Making the feature flag value to on * Lint Fix * Decorating localnav before adding events * MWPW-163912 * MWPW-163912 bug fix * MWPW-163912 bug fix * [mobile gnav] view plans and pricing CTA added is not seen visible in iphone 15 in landscape and portrait mode (adobecom#3390) * changed vh to dvh (for iphones) * made localnav curtain height lvh instead of dvh * gave localnav curtain a min height of webkit fill available * missed a semicolon * padded localnav curtain with safe-area-inset-bottom * made local nav curtain slightly larger than the view port to prevent a small space that allows clicking on the bottom * Changing the flag for new nav to off by default for standalone gnav * Removing list style * Fix for bugs MWPW-163914 and MWPW-163907 * MWPW-163912 bug fix * MWPW-164385 [Mobile Gnav]when the megamenu is opened and scrolled seen the overlapping issue on the content and screen is freezed (adobecom#3410) * the mobile mega menu on localnav pages now correctly takes scroll into account when opening * Extra pixel * MWPW-163515: add daa-ll attributes for new mobile gnav elements (adobecom#3380) * MWPW-163515: add daa-ll attributes for new mobile gnav elements * update comment * Fix: String check update for localnav * Adding disable-scroll when localnav is opened * Adding scroll for tabs * Update libs/blocks/global-navigation/utilities/utilities.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Added fix for UT and bug MWPW-163859 * Making the feature flag value to on * Lint Fix * Decorating localnav before adding events * MWPW-163912 * MWPW-163912 bug fix * MWPW-163912 bug fix * [mobile gnav] view plans and pricing CTA added is not seen visible in iphone 15 in landscape and portrait mode (adobecom#3390) * changed vh to dvh (for iphones) * made localnav curtain height lvh instead of dvh * gave localnav curtain a min height of webkit fill available * missed a semicolon * padded localnav curtain with safe-area-inset-bottom * made local nav curtain slightly larger than the view port to prevent a small space that allows clicking on the bottom * Changing the flag for new nav to off by default for standalone gnav * Removing list style * Fix for bugs MWPW-163914 and MWPW-163907 * MWPW-163515-156410: fix analytics issues * MWPW-163515: add daa-lh for localnav --------- Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <devashish.3093@gmail.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [MWPW-160542] - LNAV accessibility * Rempoving bold from multi level dropdown * Making color of feds headline for localnav to link color * [MWPW-164088] - UT fixes * Lint fixes * [MWPW-164443] - Bug fix * [MWPW-160542] - Accessibility Fixes * UT and Lint Fixes * [MWPW-160542] - Accessibility Fixes * [MWPW-160542] - Accessibility Fix for breadcrumb * [MWPW-164648] & [MWPW-164649] Bug fix * Fix: Checking for viewport before decorating localnav * [MWPW-164649] - accesibility fix for custom links * Fix: Adding checks for valid localNav * Fix: font fix for button * Lint fix * Decorating localnav * Hiding localnav on desktop view * MWPW-163916 [Mobile GNAV] | Flickering issue while scrolling when LNAV is opened (adobecom#3419) * Add overflow hidden to html if the body has it for iOS safari * Added position fixed to disable scroll for ios safari * use position: relative instead of fixed * undo previous changes * removed position absolute from the feds localnav curtain * removed the different height when the localnav curtain is active * trying position: absolute f=to prevent scrolling on iOS * add overflow hidden to html tag as when the body has it * Undo previous change * Used event.preventDefault on a scroll event on the window to prevent scrolling in iOS * tried event.preventDefault to stop body from scrolling on iOS Safari * Set the scroll to the current number on scroll when scroll is disabled * Change scroll to touchmove * iOS safari defaults event listener passive to true * Small refactor * disabled scroll for the non localnav mobile gnav as well * remove scroll on body instead of window * Disable body scroll when local nav or mobile menu is open * corrected the import * fixed a typo * Use position fixed to prevent scrolling in iOS * eslint * more eslint problems * Fixed an issue where swtiching from mobile to desktop made the dekstop mega menu popup have the wrong position * gave ios-disable-scroll the correct behavior for non localnavs as well * Fixed a couple of bugs * fixed an issue where firefox treats position fixed as position absolute * [MWPW-164624] - Bug fix * MWPW-164817 [Mobile GNAV] | The close button is not visible when the hamburger menu is clicked, and the screen shifts when clicking on the Adobe Creative Cloud drop-down (adobecom#3432) Fixed an issue on ios Safari where position fixed was changing the dimensions of the body element * Adding support for no megamenu localnav (adobecom#3421) * Mobile gnav tests (adobecom#3433) * Fixed unit tests for gnav promo * Prevent other tests from breaking * Added a test case for safari * Added an escape test for localnav * Mobile Gnav Standalone Localnav curtain was missing some styles (adobecom#3435) * Added styles necessary for the standalone localnav to function * missed a css variable * Css fix for Megamenu title * Css fix for standalone localnav * Css fix for standalone localnav * Making gnav promo sticky (adobecom#3434) * Moving Promo out of Header * Moving Promo out of Header * Cls fix for promo * Handling desktop gnav sticky * Removing has promo if no promo * Css fix * Test case fix * Test case fix * Test case fix * Test case fix * Fixed popup with promo (adobecom#3436) * Font size fix for tabs * Fixed the popup position for when there is no promo (adobecom#3439) add a condition for when the nav promo offset is subtracted from the top of the popup * [MWPW-164444] and [MWPW-164624] bug fixes * Adding shadow to localnav bottom * Popup position fix for iPhone (adobecom#3440) * add a condition for when the nav promo offset is subtracted from the top of the popup * fixed popup height for iphone * moved the popup 1px up * Added a style for non sticky lnav with a promo on ios (adobecom#3441) * [MWPW-164949] Bug Fix * Fixed more issues specific to iOS (adobecom#3448) * MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout (adobecom#3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place * Make mobile styles the default * Mobile Gnav Redesign for Adobe Home (adobecom#3151) * fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode * Mobile gnav breadcrumbs new design (adobecom#3155) * Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css * Fixing css for no breadcrumbs page * Adding main menu placeholder (adobecom#3157) * Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix * Keyboard navigation for mobile gnav redesign (adobecom#3158) * Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue * Localnav design and event listeners (adobecom#3164) * Localnav design and event listeners * Lint fix * Adding Overview title support * Handling CLS issue for localnav - mobile gnav redesign (adobecom#3198) * Handling CLS issue by preserving space for localnav * Adding localnav config * Adding overview text from placeholder * Adding meta data check for new mobile gnav feature flag * Lint fix * Adding localnav only when mobile gnav v2 is true * Adding image support for large menu and medium menus on gnav (adobecom#3235) * Adding image support on gnav * Decorating localnav only if it has one section * Lint fix * Fixing dropdown promise issue * Handle CLS issue on localnav: mobile redesign (adobecom#3253) * Check for localnav * Moving getGnanSource to utils * Awaiting gnav source * Adding lanalog when there is mismatch with content and name * Lint fixes * Changing height of localnav * Temp window url for testinf * Temp window url for testing * Added Analytics Attributes to Tabs and Tabpanels (adobecom#3275) * Added analytics attributes to tabs and tabpanels * Handle cases where we don't find daa attributes * [MWPW-159665] - Gnav redesign animations (adobecom#3234) * MWPW-161082 [Base Implementation] Mobile Global Nav Redesign Rollout (adobecom#3092) * basic functionality of mobile gnav * Made the localnav sticky, and the gnav not sticky when there is a local nav * Local nav now resides outside header to make it sticky correctly * fixed a few small css details when opening and closing the mega menu * render the mainmenu on non local nav pages and the brand icon on local nav pages on the mega menu * don't show local nav unless it's in the right place * Make mobile styles the default * Mobile Gnav Redesign for Adobe Home (adobecom#3151) * fix the popup showing up for a split second when the hamburger menu is first opened * Undid the previous commit because it didn't work * switched out animations to transitions for fedspopup * Made section buttons have a margin while regular navlinks occupy the whole space * Fixed section menu spacing * Spacing of section after navlink on adobe home * Like the previous commit but actually works * divider line * changed last of kind to last of type * fixed divider spacing * link spacing * we need to pad the last nav link as well * nav link font size * rules apply only to the links not the sections * fixed the selector for the previous commit * I sure hope it works this time * Fixed the navLinks in light mode * Mobile gnav breadcrumbs new design (adobecom#3155) * Breadcrumbs design change * Hide breadcrumbs on first sidebar * Fixing no breadcrumbs page * Fixing css * Fixing css for no breadcrumbs page * Adding main menu placeholder (adobecom#3157) * Adding main menu placeholder * Avoiding replaceText if localNav * Lint fix * Keyboard navigation for mobile gnav redesign (adobecom#3158) * Keyboard navigation for mobile gnav redesign * close main menu on escape * fixed lint issue * Localnav design and event listeners (adobecom#3164) * Localnav design and event listeners * Lint fix * Adding Overview title support * Added animations for mobile redesign * Polish animations * Polish animations * polish animations * Resolved comment --------- Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Raghav Sharma <raghavs@adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> * Adding active column logic in a large menu (adobecom#3276) * Adding active column logic in a large menu * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [MWPW-159667] - Add dark mode fixes (adobecom#3285) * dark mode changes * lint-fix * small fix for animation * Fix spacing and dark mode things for localnav * Set page overlay for local nav * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation * Added some pending fix for keyboard navigation * [MWPW-163735] - Added Local Nav keyboard navigation for mobile GNAV redesign (adobecom#3321) * Added localnav keyboard navigation for mobile gnav redesign * Added fixes for Local nav along with keyboard navigation * lint fix * Gnav bugs (adobecom#3346) * Fixing mega menu CTA height * Localnav z index and removing default makeActiveTab call * Localnav z index to 9 * Fix: georouting issue * [MWPW-164088] - UT for mobile GNAV redesign (adobecom#3359) * UT for mobile GNAV redesign * lint fix * lint fix * lint fix * lint fix * Added More UT's * Making localnav auto dismiss on click outside (adobecom#3368) * Making localnav auto dismiss on click outside * making active link in localnav bold * Fix for multi level localnav click * UT fixes * Making localnav close on curtain click * Fix: String check update for localnav * Adding disable-scroll when localnav is opened * Adding scroll for tabs * Update libs/blocks/global-navigation/utilities/utilities.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Added fix for UT and bug MWPW-163859 * Making the feature flag value to on * Lint Fix * Decorating localnav before adding events * MWPW-163912 * MWPW-163912 bug fix * MWPW-163912 bug fix * [mobile gnav] view plans and pricing CTA added is not seen visible in iphone 15 in landscape and portrait mode (adobecom#3390) * changed vh to dvh (for iphones) * made localnav curtain height lvh instead of dvh * gave localnav curtain a min height of webkit fill available * missed a semicolon * padded localnav curtain with safe-area-inset-bottom * made local nav curtain slightly larger than the view port to prevent a small space that allows clicking on the bottom * Changing the flag for new nav to off by default for standalone gnav * Removing list style * Fix for bugs MWPW-163914 and MWPW-163907 * MWPW-163912 bug fix * MWPW-164385 [Mobile Gnav]when the megamenu is opened and scrolled seen the overlapping issue on the content and screen is freezed (adobecom#3410) * the mobile mega menu on localnav pages now correctly takes scroll into account when opening * Extra pixel * MWPW-163515: add daa-ll attributes for new mobile gnav elements (adobecom#3380) * MWPW-163515: add daa-ll attributes for new mobile gnav elements * update comment * Fix: String check update for localnav * Adding disable-scroll when localnav is opened * Adding scroll for tabs * Update libs/blocks/global-navigation/utilities/utilities.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Added fix for UT and bug MWPW-163859 * Making the feature flag value to on * Lint Fix * Decorating localnav before adding events * MWPW-163912 * MWPW-163912 bug fix * MWPW-163912 bug fix * [mobile gnav] view plans and pricing CTA added is not seen visible in iphone 15 in landscape and portrait mode (adobecom#3390) * changed vh to dvh (for iphones) * made localnav curtain height lvh instead of dvh * gave localnav curtain a min height of webkit fill available * missed a semicolon * padded localnav curtain with safe-area-inset-bottom * made local nav curtain slightly larger than the view port to prevent a small space that allows clicking on the bottom * Changing the flag for new nav to off by default for standalone gnav * Removing list style * Fix for bugs MWPW-163914 and MWPW-163907 * MWPW-163515-156410: fix analytics issues * MWPW-163515: add daa-lh for localnav --------- Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <devashish.3093@gmail.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * [MWPW-160542] - LNAV accessibility * Rempoving bold from multi level dropdown * Making color of feds headline for localnav to link color * [MWPW-164088] - UT fixes * Lint fixes * [MWPW-164443] - Bug fix * [MWPW-160542] - Accessibility Fixes * UT and Lint Fixes * [MWPW-160542] - Accessibility Fixes * [MWPW-160542] - Accessibility Fix for breadcrumb * [MWPW-164648] & [MWPW-164649] Bug fix * Fix: Checking for viewport before decorating localnav * [MWPW-164649] - accesibility fix for custom links * Fix: Adding checks for valid localNav * Fix: font fix for button * Lint fix * Decorating localnav * Hiding localnav on desktop view * MWPW-163916 [Mobile GNAV] | Flickering issue while scrolling when LNAV is opened (adobecom#3419) * Add overflow hidden to html if the body has it for iOS safari * Added position fixed to disable scroll for ios safari * use position: relative instead of fixed * undo previous changes * removed position absolute from the feds localnav curtain * removed the different height when the localnav curtain is active * trying position: absolute f=to prevent scrolling on iOS * add overflow hidden to html tag as when the body has it * Undo previous change * Used event.preventDefault on a scroll event on the window to prevent scrolling in iOS * tried event.preventDefault to stop body from scrolling on iOS Safari * Set the scroll to the current number on scroll when scroll is disabled * Change scroll to touchmove * iOS safari defaults event listener passive to true * Small refactor * disabled scroll for the non localnav mobile gnav as well * remove scroll on body instead of window * Disable body scroll when local nav or mobile menu is open * corrected the import * fixed a typo * Use position fixed to prevent scrolling in iOS * eslint * more eslint problems * Fixed an issue where swtiching from mobile to desktop made the dekstop mega menu popup have the wrong position * gave ios-disable-scroll the correct behavior for non localnavs as well * Fixed a couple of bugs * fixed an issue where firefox treats position fixed as position absolute * [MWPW-164624] - Bug fix * MWPW-164817 [Mobile GNAV] | The close button is not visible when the hamburger menu is clicked, and the screen shifts when clicking on the Adobe Creative Cloud drop-down (adobecom#3432) Fixed an issue on ios Safari where position fixed was changing the dimensions of the body element * Adding support for no megamenu localnav (adobecom#3421) * Mobile gnav tests (adobecom#3433) * Fixed unit tests for gnav promo * Prevent other tests from breaking * Added a test case for safari * Added an escape test for localnav * Mobile Gnav Standalone Localnav curtain was missing some styles (adobecom#3435) * Added styles necessary for the standalone localnav to function * missed a css variable * Css fix for Megamenu title * Css fix for standalone localnav * Css fix for standalone localnav * Making gnav promo sticky (adobecom#3434) * Moving Promo out of Header * Moving Promo out of Header * Cls fix for promo * Handling desktop gnav sticky * Removing has promo if no promo * Css fix * Test case fix * Test case fix * Test case fix * Test case fix * Fixed popup with promo (adobecom#3436) * Font size fix for tabs * Fixed the popup position for when there is no promo (adobecom#3439) add a condition for when the nav promo offset is subtracted from the top of the popup * [MWPW-164444] and [MWPW-164624] bug fixes * Adding shadow to localnav bottom * Popup position fix for iPhone (adobecom#3440) * add a condition for when the nav promo offset is subtracted from the top of the popup * fixed popup height for iphone * moved the popup 1px up * Fixed popup not showing properly on safari * added padding-bottom: env(safe-area-inset-bottom) for our popup * min height 100dvh * removed min height and moved back to the old height * ios html height must be 100dvh * + should be has --------- Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <devashish.3093@gmail.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com> * Fixing promo on a page with a main menu (adobecom#3449) * quick fix for popup in older ios versions * Fixing promo on a page with a main menu * Fix mainmenu color in ios and promo texxst dissappearing under certain circumstances. (adobecom#3450) * quick fix for popup in older ios versions * Fixing promo on a page with a main menu * changed the selector for changing the header z index to more accurately target a dropdown * explicitly set main menu button color * Mobile gnav main promo (adobecom#3451) * corrected a selector * [MWPW-164949] Bug Fix * Mobile gnav bugfixes (adobecom#3452) * fixed popup on page with promo and mainmenu * Gave the body a min-height * Reserve space for the gnav promo on mobile (adobecom#3453) * Mobile gnav bugfixes (adobecom#3464) * Reserve space for the gnav promo on mobile * popup.style.top should only be set for localnav * Gave the globalnav with promo the correct height and position * scroll behavior set to instant * MWPW-164737: add daa-ll for new gnav-image element (adobecom#3466) * Changing the override character to :: for localnav title (adobecom#3470) * MWPW-165391 [Mobile-GNav] when the page is opened and navigated till center and clicked on tabs the screen is taken up (adobecom#3467) Changed tabs scrollStackedMobile to work correctly with a sticky localnav * Adding check for new nav before checking for mega menu to render hamburger * Enable Scroll in Lnav while disabling it in gnav (adobecom#3472) * enable scrolling on localnav but not on popup * fixed an issue where there was a 1 px gap between the popup and the top of the page * Removed commented lines * Removed a unit test that was no longer necessary * disable ios scroll only on localnav * disable mobile scroll always for feds popup * disable scroll in the right place * enable mobile scroll when clicking main menu * guarded agains disable mobile scroll being called twice * don't disable scroll when lnav curtain is clickerd * Unit tests for enable/disable scroll * Fixed screen freeze when clicking on a localnav item * disable scroll only on megamenu * Fix for popup title on specific DC pages * box-sizing inheritances * Adding check for localnav before setting the top for sticky top section metadata (adobecom#3484) Adding localnav check for style top * Adding promo check for style top * Adding promo check for style top * Lint fix * Fix for a unit test --------- Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Raghav Sharma <raghavs@adobe.com> Co-authored-by: Dev Ashish Saradhana <41122199+Deva309@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dev Ashish Sardana <devashish.3093@gmail.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com>
to test body aria-live
* initial commit * initial commit. still need to fix tests * initial commit * added pagination summary + min 2 chars for seatch API trigger * added pagination summary + min 2 chars for seatch API trigger * added pageNum to shareUrl * changed pagination summary * changed pagination summary * css updates * css updates * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * remove unneeded data from DOM * center button text with new count * even spacing for form fields * change to filter * removed dead code = css fix for mobile view for share button * css fix for pagination on mobile * lint error fix --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: vgoodric <vgoodric@adobe.com>
* [Nala] Fix failing promo code in Nala tests * mas: update Nala test
…adobecom#3489) Add pageview send event, fix window.stallite empty issue
* Taking localnav height only when it is visible * Fixing top for gnav since promo is not inside gnav anymore * Code fix * Feds promo wrapper rule should be ins tyles.css to avoid CLS * Check for newNav search param when reserving space for the localnav --------- Co-authored-by: Raghav Sharma <raghavs@adobe.com>
…t.js (adobecom#3469) * fixed the flaky test * move performance mock to beforeEach/afterEach for isolation, simplify lcpElType check * removed unused code * fixed the same issue in logWebVitals.test.js and reverted unnecessary changes * Updated README.md
…om#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit
* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)" This reverts commit 81a5770. * MWPW-165523: Fixes BETA Caas bulkpublisher auto-detect * Minor css fix --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
* MWPW-162385 add wcsApiKey attribute * MWPW-161355: Update MAS documentation (adobecom#3135) * MWPW-159374: Update hydrate logic to support all cta styles organise code and code coverage Update tests * add workaround for ccd-suggested cards * remove source maps * improve code coverage * merge MWPW-159374 * MWPW-161355: Update MAS documentation * Example with contextual menu * Checkout click event with correct event target when the CTA contains a text wrapped by a span * cleanup all attributes during card hydration * remove deps/mas/mas.js * update test * update doc * allow list libs/features/mas/mas/dist/mas.js * change order in ignore * trying with wildcard * allow list dist * update hlxignore rules * update hlxignore rules * MWPW-161176: restructure ccd gallery (adobecom#3169) restructure ccd gallery * fix mas path * fix undefined error in merch-icon * fix regression in ctas size * update doc * fix css with checkout-link * fix random rtl issue * revert removal of mas.js from deps * update ccd gallery --------- Co-authored-by: Mariia Lukianets <lukianet@adobe.com> * MWPW-161845: basic analytics on mas cards (adobecom#3206) * MWPW-161845: add analytics * fix review changes * add build files * MWPW-159191: MAS Freyja support (adobecom#3209) * initial freyja commit * increase codecov * trival * add qa support to ccd page * improve page performance * update ccd.html * MWPW-161804: Merch card style auditing (adobecom#3216) Refactor merch-card styles to improve structure and specificity * Added space after price recurrence label for display-per-unit prices (adobecom#3196) * Added space after price recurrence label for display-per-unit prices * more specific selector * built * fix cr * built * adding example * MWPW-162933: merge mas modules (adobecom#3248) * MWPW-162933: merge mas modules + consonant-templates module from tacocat.js into a single module * MWPW-160755 - add tests for CCD cards (adobecom#3256) * MWPW-160755 - add tests for CCD cards * refactor and prepare dark mode checks * add tests for slice cards * activate dark for suggested and eslint fixes * add check for cta variant * fix multi mnemonic check * fix lint * add analytics check * remove comment * MWPW-163041: analytics fix (adobecom#3257) * MWPW-163041: fix analytics & add docs * add tests for analytics * add analytics docu * fix test * Fix overriding of border style on merch cards (adobecom#3278) * Fix overriding of border style on merch cards * width change * built --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> * Bump timeout from 2 to 10 sec (adobecom#3282) * bump to 10 seconds * new change * MWPW-163479: Switch to Spectrum CSS from SWC CCD app already provides Spectrum CCS styles. * update doc style * update doc style * update doc style * update doc style * update doc style * update doc style * Update styles * update docs * Keep SWC logic as an option * MWPW-161645: lana logging for CCD (adobecom#3271) * MWPW-161645: lana logging for CCD with <mas-commerce-service data-lana-tags="consumer=ccd" ...> lana will be enabled. TODO: Update docs * Update tests * fix review comments * add host env attribute, fix lana override * fix docs * fix unit tests * start loggin missing osi's * fix message * fix message * Update libs/features/mas/src/lana.js Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * PR review changes * avoid duplicate logging, log wcs url, limit page length in log * fix formatString error * fix render * add tests * fix loggin * revert ccd comments * fix milo tags --------- Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * fix gaps with Spectrum CSS support * update version * fix gaps reported by ccd teamm * address gaps * address gaps * address gaps * address gaps * address gaps * fix for MWPW-163718 addressed design gaps. * addressed design gaps. * bump the version * add build artifacts * Update colors based on CCD app * Update colors based on CCD app * build without source maps * update Nala tests * fix lint * reset box-sizing for merch-card elements * Force box-sizing on merch-card * update styles: box-sizing * fix ccd gallery * update version * limit ccd price style to their variants * limit ccd price style to suggest variant * preserve white spaces in prices section * fix spacing in price * Update version * Update doc * update cards * update gallery styles * make the gallery responsive * align slice card ctas * cards resize responsively * fix 1x of gap issue * fix description text alignement * fix gaps in minimal widths * fix the gallery layout * Fix strikethrough price color in promos * Update nala tests * MWPW-164177: clean up card style on fragment * Added a new section to ccd gallery * update mas version * fix missing default spectrum css button style * WIP * fix tabindex * fix nala tests * MWPW-164484: fix see terms focus indicator * MWPW-164484: fix see terms focus indicator * increase codecov * Update doc * Update doc * rename constant * Restrict updateLinks to spectrum css * revert env related doc changes * revert merch modal change * revert merch modal change * add data-href attribute to checkout-button element * Update libs/features/mas/docs/src/mas.js.md Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> * fix docs * Fix style regressions * remove broken link * update doc * fix styles --------- Co-authored-by: Nicolas Peltier <npeltier@adobe.com> Co-authored-by: Mariia Lukianets <lukianet@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com> Co-authored-by: Milica Micic <cod23684@adobe.com> Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
…dobecom#3424) * authorable solution * Updated copy for progress bar * code optimization * unit tests * eslint * milolibs fix * milolibs fix * Restructured the code and followed review comments * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * code review * ecid * Removed circle loader as it is not required * shortened variable names * moved css to branch-quick-links.css * cleaned css * changed authoring * Handled loader delay * Reverting UTs * modified UTs * UT fix * Unit tests * review changes --------- Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.macromedia.com>
resolve conflicts with refactored code
ENB-7642: Remove console errors and update test cases
* Hamburger icon issue fix * Hamburger icon issue fix * Hamburger icon issue fix * app banner with level 2 screen issue fix as primary cta not visible * app banner with level 2 screen issue fix as primary cta not visible * Header with navPromo top should be for all viewports * [MWPW-165142] Bug Fix * Add UT
* Don't merge PRs with running tests * Adapt check to disregard skipped checks
… states or properties - Change Region (adobecom#3486) * fixing accessibility issue * Addressing review comment for dropdown --------- Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
* Initial commit for rollout plugin * Refactoring * Update rollout plugin based on new requirement and locv3 * Refactoring and adding tests * Adding check for non langstore urls * Adding warning message
* [MWPW-165790] accordion aria-expanded fix * [MWPW-165790] revert file line
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| document.querySelectorAll('code.demo').forEach(el => { | ||
| const targetContainer = document.createElement('div'); | ||
| targetContainer.classList.toggle('light', el.classList.contains('light')); | ||
| targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`; |
Check failure
Code scanning / CodeQL
DOM text reinterpreted as HTML High documentation
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that any text content extracted from the DOM and reinserted as HTML is properly escaped to prevent XSS attacks. This can be achieved by using a function to escape HTML special characters before assigning the text to innerHTML.
- Create a function to escape HTML special characters.
- Use this function to escape
el.textContentbefore inserting it into the HTML string.
Suggested changeset
1
libs/features/mas/docs/checkout-button.html
| @@ -342,2 +342,15 @@ | ||
| <script type="module"> | ||
| function escapeHTML(str) { | ||
| return str.replace(/[&<>"']/g, function(match) { | ||
| const escapeMap = { | ||
| '&': '&', | ||
| '<': '<', | ||
| '>': '>', | ||
| '"': '"', | ||
| "'": ''' | ||
| }; | ||
| return escapeMap[match]; | ||
| }); | ||
| } | ||
|
|
||
| document.querySelectorAll('code.demo').forEach(el => { | ||
| @@ -345,3 +358,3 @@ | ||
| targetContainer.classList.toggle('light', el.classList.contains('light')); | ||
| targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`; | ||
| targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${escapeHTML(el.textContent)}</div>`; | ||
| el.parentElement.after(targetContainer); |
Copilot is powered by AI and may make mistakes. Always verify output.
| extraOptions, | ||
| }); | ||
| if (innerHTML) | ||
| element.innerHTML = `<span style="pointer-events: none;">${innerHTML}</span>`; |
Check warning
Code scanning / CodeQL
Unsafe HTML constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to ensure that the innerHTML value is sanitized before being set. This can be done by either using a safe API like textContent or by sanitizing the input using a library like DOMPurify. In this case, we will use DOMPurify to sanitize the input, ensuring that any potentially unsafe HTML is removed.
- Install the
dompurifylibrary. - Import
DOMPurifyin the relevant file. - Use
DOMPurify.sanitizeto sanitize theinnerHTMLvalue before setting it.
Suggested changeset
2
libs/features/mas/src/checkout-mixin.js
| @@ -1,2 +1,3 @@ | ||
| import { ignore } from './external.js'; | ||
| import DOMPurify from 'dompurify'; | ||
| import { | ||
| @@ -42,4 +43,6 @@ | ||
| }); | ||
| if (innerHTML) | ||
| element.innerHTML = `<span style="pointer-events: none;">${innerHTML}</span>`; | ||
| if (innerHTML) { | ||
| const sanitizedInnerHTML = DOMPurify.sanitize(innerHTML); | ||
| element.innerHTML = `<span style="pointer-events: none;">${sanitizedInnerHTML}</span>`; | ||
| } | ||
| return element; |
libs/features/mas/package.json
Outside changed files
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.2.3 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
| el.log.error('test error'); | ||
| const [, url] = calls[0].open.lastCall.args; | ||
| expect( | ||
| /https\:\/\/www.stage.adobe.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test( |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we need to escape the . character in the regular expression to ensure that it only matches the literal . character and not any character. This can be done by replacing . with \. in the regular expression. Specifically, we need to update the regular expression on line 157 to escape the . before adobe.com.
Suggested changeset
1
libs/features/mas/test/mas-commerce-service.test.js
| @@ -156,3 +156,3 @@ | ||
| expect( | ||
| /https\:\/\/www.stage.adobe.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test( | ||
| /https\:\/\/www\.stage\.adobe\.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test( | ||
| url, |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-NUMBER
Test URLs: