Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
b72ed94
Sync stage and main (#3326)
mokimo Dec 6, 2024
02bf866
MWPW-161015 Adds new segment-timeline classes (#3328)
markpadbe Dec 9, 2024
e9f0bf2
Adding Standalone gnav's default allowed origins (#3329)
bandana147 Dec 9, 2024
81a5770
MWPW-140452 - Icon authoring in milo using the federal repo and indiv…
ryanmparrish Dec 9, 2024
93b846c
[MWPW-163539] Update RCP workflow (#3296)
overmyheadandbody Dec 9, 2024
7483f29
MWPW-156157 use OST v1.19.1 (#3290)
npeltier Dec 9, 2024
57d66cf
[MWPW-163723] [NALA] Update Nala CircleCI Job to Manual Trigger (#3317)
skumar09 Dec 9, 2024
9884681
MWPW-154147: add spectrum switch component (#3264)
SonjaPopovic Dec 9, 2024
39eafc8
[NALA][Table-Tooltip] Update tooltip locator (#3335)
skumar09 Dec 9, 2024
cdd773a
[ENB-7566] Change domain names for stage, remove personalization logi…
swamu Dec 10, 2024
57c5490
Adding helpx and stock url to prodDomains for standalone gnav (#3333)
bandana147 Dec 10, 2024
cc05e05
[MWPW-161870] Fixing the issue that sidenav can't be collapsed. (#3201)
seanchoi-dev Dec 10, 2024
e38ff7c
MWPW-162929: Implements qa feedback and other improvements (#3299)
cmiqueo Dec 10, 2024
00c690b
Cumulative Commerce PR post-RCP (#3297)
3ch023 Dec 10, 2024
6c756bc
[ENB-7567] Remove ee from the link (#3347)
swamu Dec 10, 2024
4e29c5c
chore: Ignore tmp folders (#3336)
hparra Dec 11, 2024
2be5754
MWPW-159180 [MILO][MEP] MEP Manifest Manager (#3344)
vgoodric Dec 11, 2024
4c20774
MWPW-155723 - Adds group metadata to ensure dynamic nav continuity - …
JasonHowellSlavin Dec 11, 2024
4bbfba0
MWPW-163754 Color difference is seen in the milo pages (#3330)
suhjainadobe Dec 11, 2024
74735f0
MWPW-163987: change cta colour on merch card (#3350)
3ch023 Dec 11, 2024
d19c2c7
Fix optional profile page detail in the sidekick (#3349)
mokimo Dec 11, 2024
b49d012
MWPW-157864 [Catalog] Localise external modals (#3277)
bozojovicic Dec 11, 2024
0052f31
Revert "MWPW-140452 - Icon authoring in milo using the federal repo a…
mokimo Dec 11, 2024
635c26b
Carousel update for SharePoint video sizing (#3265)
rgclayton Dec 11, 2024
6b2d5c6
MWPW-161872: Self host marketo's forms2.min.js (#3215)
JasonHowellSlavin Dec 11, 2024
28dc5d2
Revert "MWPW-163754 Color difference is seen in the milo pages" (#3365)
suhjainadobe Dec 12, 2024
d543279
[MWPW-164170] Update RCP dates for 2025 (#3371)
overmyheadandbody Dec 12, 2024
a33a005
MWPW-163490[MEP][NALA] add basic mep-actions test (#3292)
jpratt2 Jan 2, 2025
e4ad9d4
[MWPW-158015] [Mini Compare Merch Card] Redesign mini compare card fo…
rohitsahu Jan 2, 2025
a0bc4a5
[LOC]MWPW-163380 - Missing project details locui create (#3295)
saurabhsircar11 Jan 2, 2025
01ffecc
MWPW-163379: Fix edit url from Helix admin API for DA (#3314)
sharmeebuilds Jan 2, 2025
cfa308b
MWPW-163892 Fix Chat Icon Cut Off (#3363)
meganthecoder Jan 2, 2025
eefbd36
MWPW-159180 & 164118 [MMM] MEP Manifest Manager Fast Follow (#3364)
vgoodric Jan 2, 2025
f472180
[MWPW-160864] Adapt action item focus state (#3398)
overmyheadandbody Jan 2, 2025
c36fb32
MWPW-162839: Move title-append to loadArea (#3341)
hparra Jan 2, 2025
29d77a6
[MWPW-164097] Allow special chars in aria-label definition (#3362)
overmyheadandbody Jan 2, 2025
a2443c0
ServiceNow CMR integration (#3392)
amauch-adobe Jan 3, 2025
d389752
Add unc activity feed support for standalone gnav (#3386)
bandana147 Jan 7, 2025
7db0ff0
MWPW-163479: MAS - Switch to Spectrum CSS from SWC (#3289)
yesil Jan 7, 2025
ea9f4a9
MWPW-150560 make search literals usable as fragments (#3320)
npeltier Jan 7, 2025
238caed
MWPW-162046 Tabs - Stacked Mobile (#3351)
meganthecoder Jan 7, 2025
e4f9999
MWPW-164084 [Catalog] Page position not preserved after closing the m…
bozojovicic Jan 7, 2025
d53dab7
[MWPW-161858] Remove sticky section when footer is visible (#3402)
robert-bogos Jan 7, 2025
e7fc894
MWPW-159299 Add chart role and dynamic aria labels (#3404)
Brandon32 Jan 7, 2025
b063e5d
MWPW-156410: add daa-lh/ll values for gnav promo (#3413)
nishantka Jan 7, 2025
82694a3
MWPW-162760 [MEP] Issues with inline fragments (#3415)
vgoodric Jan 7, 2025
faf70c2
MWPW-162795: Complimentary/Product Entry CTAs (#3354)
akanshaa-18 Jan 9, 2025
bfe9f9b
MWPW-164227 add checkmark animation on successful form submit (#3397)
vhargrave Jan 9, 2025
73cb4e7
MWPW-162722: Sticky promo banner loading issue (#3263)
sivasadobe Jan 9, 2025
0c20425
MWPW-161865: adds alt text attribute to background images of merch ca…
Axelcureno Jan 9, 2025
dd15662
MWPW-164094 Fix algorithm for calculation of PUF optical (#3370)
bozojovicic Jan 9, 2025
5ed9985
[MWPW-164327] BulkPublisher BETA does not detect non-US lang & locale…
cmiqueo Jan 9, 2025
a8222fd
fix(Mwpw-163747):fix for accessibility bugs. (#3381)
sharath-kannan Jan 9, 2025
56b944a
MWPW-160811 [coll] allow search & results & total digit token with / …
npeltier Jan 9, 2025
06c149b
MWPW-164638 and 164805 MMM refine values for save and add manifest co…
vgoodric Jan 9, 2025
5bbb0bf
language based region nav config (#3425)
vhargrave Jan 9, 2025
c582faa
Fix(MWPW-164736):Table header cell height fix. (#3429)
sharath-kannan Jan 9, 2025
b6e2bcd
MWPW-163603 benchmark card rendering time in PR (#3377)
npeltier Jan 13, 2025
239f08a
Updating package version for bundled standalone gnav (#3423)
bandana147 Jan 13, 2025
e01e1bf
MWPW-162308 Update focus to convey state (#3427)
Brandon32 Jan 13, 2025
1ce78a0
MWPW-163166: Enables scroll to on ungated forms (#3437)
JasonHowellSlavin Jan 13, 2025
ef0d2ce
Notification pill variant needs 16px spacing below it (#3445)
rgclayton Jan 13, 2025
be5c164
Adding save today to ctaTextOption (#3458)
seanchoi-dev Jan 13, 2025
746f58e
[MWPW-163381] : Removed lorem ipsum text check from preflight modal (…
sharmeebuilds Jan 13, 2025
2d5b5bf
Setting aria-live to shadowRoot element instead to the slot. (#3389)
seanchoi-dev Jan 14, 2025
c58ef7d
List accessibility for quiz-marquee (#3460)
colloyd Jan 14, 2025
95d3ce2
fixing unit test (#3480)
npeltier Jan 14, 2025
e5c69e9
MWPW-164107: Mnemonic list fixed (#3372)
Axelcureno Jan 15, 2025
3d79cc1
New Mobile gnav 1.2 redesign (#3374)
bandana147 Jan 15, 2025
201299e
Adding body aria-live to merch card - product (#3447)
seanchoi-dev Jan 15, 2025
a1c1cca
[MWPW-165303]: MMM - Implemented BE Pagination (#3462)
denlight Jan 15, 2025
62d554b
mas: update failing Nala test on stage (#3490)
afmicka Jan 15, 2025
62d03e5
[ENB-7645] Add page-view send event, fix window.satellite empty issue…
swamu Jan 15, 2025
6718d23
Taking localnav height only when it is visible (#3488)
bandana147 Jan 15, 2025
b1351a6
fixed the flaky test for logWebVitals.test.js & logWebVitalsUtils.tes…
skholkhojaev Jan 15, 2025
3076a7a
MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)
sharmrj Jan 16, 2025
91d1e3d
MWPW-165523: Fixes BETA Caas bulkpublisher auto-detect (#3476)
cmiqueo Jan 16, 2025
6eb0401
MWPW-163845: Merch-card a11y fix for CTAs (#3403)
yesil Jan 16, 2025
bb7ef3d
[MWPW-164132] Implementing Branch Quick Links with ECID Integration (…
drashti1712 Jan 20, 2025
965a8c6
MWPW-161625: fix mas:pending event on requestUpdate (#3388)
3ch023 Jan 20, 2025
d75cf85
[ENB-7642] Remove Console logs (#3477)
swamu Jan 20, 2025
c1dd016
[MWPW-165782] - Hamburger icon issue fix (#3501)
Deva309 Jan 20, 2025
66f90cb
Don't merge PRs with running tests (#3481)
mokimo Jan 20, 2025
c88d80c
MWPW-164735 - States/Properties: The element has missing or incorrect…
sonawanesnehal3 Jan 20, 2025
e4558c9
MWPW-146930 - Rollout tool plugin (#3463)
sabyamon Jan 20, 2025
a4101ed
[MWPW-165790] accordion aria-expanded fix (#3502)
DKos95 Jan 21, 2025
8ab6603
listen to publish events
mokimo Jan 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .github/codeql/codeql-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ paths-ignore:
- 'tools/translation/**'
- node_modules
- libs/deps/mas
- libs/features/mas/dist
73 changes: 50 additions & 23 deletions .github/workflows/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,57 +3,83 @@
const owner = process.env.REPO_OWNER || ''; // example owner: adobecom
const repo = process.env.REPO_NAME || ''; // example repo name: milo
const auth = process.env.GH_TOKEN || ''; // https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
const CURRENT_YEAR = 2024;
const RCPDates = [
{
start: new Date('2024-05-26T00:00:00-07:00'),
end: new Date('2024-06-01T00:00:00-07:00'),
start: new Date('2024-12-12T11:00:00-08:00'),
end: new Date('2024-12-12T14:00:00-08:00'),
},
{
start: new Date('2024-06-13T11:00:00-07:00'),
end: new Date('2024-06-13T14:00:00-07:00'),
start: new Date('2024-12-15T00:00:00-08:00'),
end: new Date('2025-01-02T00:00:00-08:00'),
},
{
start: new Date('2024-06-30T00:00:00-07:00'),
end: new Date('2024-07-06T00:00:00-07:00'),
start: new Date('2025-02-23T00:00:00-08:00'),
end: new Date('2025-03-01T00:00:00-08:00'),
},
{
start: new Date('2024-08-25T00:00:00-07:00'),
end: new Date('2024-08-31T00:00:00-07:00'),
start: new Date('2025-03-12T11:00:00-07:00'),
end: new Date('2025-03-12T14:00:00-07:00'),
},
{
start: new Date('2024-09-12T11:00:00-07:00'),
end: new Date('2024-09-12T14:00:00-07:00'),
start: new Date('2025-03-17T00:00:00-07:00'),
end: new Date('2025-03-20T17:00:00-07:00'),
},
{
start: new Date('2024-10-07T00:00:00-07:00'),
end: new Date('2024-10-18T17:00:00-07:00'),
start: new Date('2025-05-25T00:00:00-07:00'),
end: new Date('2025-05-31T00:00:00-07:00'),
},
{
start: new Date('2024-11-17T00:00:00-08:00'),
end: new Date('2024-11-30T00:00:00-08:00'),
start: new Date('2025-06-12T11:00:00-07:00'),
end: new Date('2025-06-12T14:00:00-07:00'),
},
{
start: new Date('2024-12-12T11:00:00-08:00'),
end: new Date('2024-12-12T14:00:00-08:00'),
start: new Date('2025-06-29T00:00:00-07:00'),
end: new Date('2025-07-05T00:00:00-07:00'),
},
{
start: new Date('2024-12-15T00:00:00-08:00'),
end: new Date('2025-01-02T00:00:00-08:00'),
start: new Date('2025-08-24T00:00:00-07:00'),
end: new Date('2025-08-30T00:00:00-07:00'),
},
{
start: new Date('2025-09-11T11:00:00-07:00'),
end: new Date('2025-09-11T14:00:00-07:00'),
},
{
start: new Date('2025-10-06T00:00:00-07:00'),
end: new Date('2025-10-16T17:00:00-07:00'),
},
{
start: new Date('2025-11-16T00:00:00-08:00'),
end: new Date('2025-11-29T00:00:00-08:00'),
},
{
start: new Date('2025-12-10T11:00:00-08:00'),
end: new Date('2025-12-10T14:00:00-08:00'),
},
{
start: new Date('2025-12-14T00:00:00-08:00'),
end: new Date('2026-01-04T00:00:00-08:00'),
},
];

const isWithinRCP = (offset = 0) => {
const isShortRCP = (start, end) => {
return ((end - start) / (1000 * 60 * 60)) < 24;
};

const isWithinRCP = ({ offset = 0, excludeShortRCP = false } = {}) => {
const now = new Date();
if (now.getFullYear() !== CURRENT_YEAR) {
console.log(`ADD NEW RCPs for ${CURRENT_YEAR + 1}`);
const lastRcpDate = RCPDates.reverse()[0];
if (now > lastRcpDate.end) {
console.log('ADD NEW RCPs for the current year');
return true;
}

if (RCPDates.some(({ start, end }) => {
const adjustedStart = new Date(start);
adjustedStart.setDate(adjustedStart.getDate() - offset);
return start <= now && now <= end
const match = adjustedStart <= now && now <= end;
if (!match || (excludeShortRCP && isShortRCP(start, end))) return false;
return true;
})) {
console.log(
'Current date is within a RCP (2 days earlier for stage, to keep stage clean & make CSO contributions during an RCP easier). Stopping execution.'
Expand Down Expand Up @@ -148,6 +174,7 @@ module.exports = {
getLocalConfigs,
slackNotification,
pulls: { addLabels, addFiles, getChecks, getReviews },
isShortRCP,
isWithinRCP,
RCPDates,
};
11 changes: 11 additions & 0 deletions .github/workflows/listen-to-publish-events.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
on:
repository_dispatch:
types:
- resource-published
jobs:
print:
runs-on: ubuntu-latest
steps:
- run: |
echo "Status: ${{ github.event.client_payload.status }}"
echo "Path: ${{ github.event.client_payload.path }}"
3 changes: 2 additions & 1 deletion .github/workflows/merge-to-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const {
const PR_TITLE = '[Release] Stage to Main';
const STAGE = 'stage';
const PROD = 'main';
const MIN_SOT_APPROVALS = process.env.MIN_SOT_APPROVALS ? Number(process.env.MIN_SOT_APPROVALS) : 4;

let github, owner, repo;

Expand Down Expand Up @@ -40,7 +41,7 @@ const main = async (params) => {
const stageToMainPR = await getStageToMainPR();
const signOffs = stageToMainPR?.labels.filter((l) => l.includes('SOT'));
console.log(`${signOffs.length} SOT labels on PR ${stageToMainPR.number}`);
if (signOffs.length >= 4) {
if (signOffs.length >= MIN_SOT_APPROVALS) {
console.log('Stage to Main PR has all required labels. Merging...');
await github.rest.pulls.merge({
owner,
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/merge-to-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:

env:
MILO_RELEASE_SLACK_WH: ${{ secrets.MILO_RELEASE_SLACK_WH }}
MIN_SOT_APPROVALS: ${{ secrets.MIN_SOT_APPROVALS }}

jobs:
merge-to-main:
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/merge-to-stage.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,12 @@ let body = `
const isHighPrio = (labels) => labels.includes(LABELS.highPriority);
const isZeroImpact = (labels) => labels.includes(LABELS.zeroImpact);

const hasFailingChecks = (checks) => checks.some(({ conclusion, name }) => name !== 'merge-to-stage' && conclusion === 'failure');
const hasFailingChecks = (checks) =>
checks.some(
({ conclusion, name }) =>
name !== 'merge-to-stage' &&
(conclusion === 'in_progress' || conclusion === 'failure')
);

const commentOnPR = async (comment, prNumber) => {
console.log(comment); // Logs for debugging the action.
Expand Down Expand Up @@ -90,7 +95,7 @@ const getPRs = async () => {

prs = prs.filter(({ checks, reviews, number, title }) => {
if (hasFailingChecks(checks)) {
commentOnPR(`Skipped merging ${number}: ${title} due to failing checks`, number);
commentOnPR(`Skipped merging ${number}: ${title} due to failing or running checks`, number);
return false;
}

Expand Down Expand Up @@ -231,7 +236,7 @@ const main = async (params) => {
github = params.github;
owner = params.context.repo.owner;
repo = params.context.repo.repo;
if (isWithinRCP(process.env.STAGE_RCP_OFFSET_DAYS || 2)) return console.log('Stopped, within RCP period.');
if (isWithinRCP({ offset: process.env.STAGE_RCP_OFFSET_DAYS || 2, excludeShortRCP: true })) return console.log('Stopped, within RCP period.');

try {
const stageToMainPR = await getStageToMainPR();
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/rcp-notifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ const {
slackNotification,
getLocalConfigs,
RCPDates,
isShortRCP,
} = require('./helpers.js');

const isWithin24Hours = (targetDate) =>
Math.abs(new Date() - targetDate) <= 24 * 60 * 60 * 1000;
const isWithin24Hours = (targetDate) => {
const now = new Date();
return now < targetDate && new Date(now.getTime() + 24 * 60 * 60 * 1000) > targetDate;
};

const calculateDateOffset = (date, offset) => {
const newDate = new Date(date);
Expand All @@ -19,17 +22,18 @@ const main = async () => {
for (const rcp of RCPDates) {
const start = new Date(rcp.start);
const end = new Date(rcp.end);
const isShort = isShortRCP(start, end);
const tenDaysBefore = calculateDateOffset(start, 10);
const fourDaysBefore = calculateDateOffset(start, 4);
const stageOffset = Number(process.env.STAGE_RCP_OFFSET_DAYS) || 2;
const slackText = (days) =>
`Reminder RCP starts in ${days} days: from ${start.toUTCString()} to ${end.toUTCString()}. Merges to stage will be disabled beginning ${calculateDateOffset(start, stageOffset).toUTCString()}.`;
if (isWithin24Hours(tenDaysBefore)) {
if (isWithin24Hours(tenDaysBefore) && !isShort) {
console.log('Is within 24 hours of 10 days before RCP');
await slackNotification(slackText(10), process.env.MILO_DEV_HOOK);
}

if (isWithin24Hours(fourDaysBefore)) {
if (isWithin24Hours(fourDaysBefore) && !isShort) {
console.log('Is within 24 hours of 4 days before RCP');
await slackNotification(slackText(4), process.env.MILO_DEV_HOOK);
}
Expand Down
11 changes: 2 additions & 9 deletions .github/workflows/run-mas-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@ jobs:
- name: Upload commerce coverage to Codecov
uses: codecov/codecov-action@v4
with:
name: mas-commerce
name: mas
token: ${{ secrets.CODECOV_TOKEN }}
files: libs/features/mas/commerce/coverage/lcov.info

- name: Upload web-components coverage to Codecov
uses: codecov/codecov-action@v4
with:
name: mas-web-components
token: ${{ secrets.CODECOV_TOKEN }}
files: libs/features/mas/web-components/coverage/lcov.info
files: libs/features/mas/coverage/lcov.info
6 changes: 2 additions & 4 deletions .github/workflows/run-nala-circleci.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: Nala Tests on CircleCI

on:
push:
branches:
- stage
workflow_dispatch:

jobs:
trigger-circleci:
Expand All @@ -15,4 +13,4 @@ jobs:
curl -X POST 'https://circle.ci.adobe.com/api/v2/project/gh/wcms/nala/pipeline' \
-H 'Circle-Token: ${{ secrets.CCI_TOKEN }}' \
-H 'content-type: application/json' \
-d "{\"branch\":\"main\"}"
-d "{\"branch\":\"main\"}"
1 change: 1 addition & 0 deletions .github/workflows/run-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Install dependencies
run: npm install
Expand Down
Loading
Loading