feat(NODE-7121): prevent connection churn on backpressure errors when establishing connections#4800
Merged
tadjik1 merged 5 commits intomongodb:mainfrom Dec 12, 2025
Merged
Conversation
baileympearson
force-pushed
the
NODE-7121
branch
2 times, most recently
from
f4f55f6 to
e14a3ef
Compare
baileympearson
commented
Nov 20, 2025
baileympearson
force-pushed
the
NODE-7121
branch
3 times, most recently
from
ad9299d to
151b986
Compare
5 tasks
baileympearson
force-pushed
the
NODE-7121
branch
from
541a8e0 to
70c1333
Compare
baileympearson
commented
Dec 2, 2025
baileympearson
commented
Dec 2, 2025
baileympearson
force-pushed
the
NODE-7121
branch
from
70c1333 to
d3ec74a
Compare
baileympearson
changed the title
baileympearson
commented
Dec 2, 2025
tadjik1
added
the
Primary Review
tadjik1
reviewed
Dec 8, 2025
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
Outdated
Show resolved
Hide resolved
tadjik1
reviewed
Dec 8, 2025
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
Member
|
This file is missing from the sync: |
tadjik1
requested changes
Dec 9, 2025
Member
tadjik1
left a comment
tadjik1
left a comment
There was a problem hiding this comment.
Thanks a lot @baileympearson, great work on syncing and improving tests! Just a few small comments from my side.
dariakp
requested changes
Dec 9, 2025
test/spec/server-discovery-and-monitoring/errors/error_handling_handshake.json
Show resolved
Hide resolved
dariakp
requested changes
Dec 9, 2025
test/integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
Show resolved
Hide resolved
dariakp
reviewed
Dec 11, 2025
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
LGTM pending one last comment thread above
dariakp
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR adopts the backpressure changes from mongodb/specifications#1860 and mongodb/specifications#1855.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Connection Churn Avoidance in Server Overload Scenarios
In particular server overload scenarios, the server can preemptively reject new connections to avoid further overloading itself. This can cause connection churn in the driver's connection pool, as each connection failure clears the pool.
Connection establishment failures no longer clear the pool, preventing connection churn in these scenarios.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript