Skip to content

Add support for Danders Frames #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reloe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Danders Frames #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca1e1c
Add support for Danders Frames
Reloe Jan 22, 2026
875d077
Add secret value check to prevent errors in raid combat
Reloe Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions LibGetFrame-1.0.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
local MAJOR_VERSION = "LibGetFrame-1.0"
local MINOR_VERSION = 69
local MINOR_VERSION = 70
if not LibStub then
error(MAJOR_VERSION .. " requires LibStub.")
end
Expand Down Expand Up @@ -49,6 +49,9 @@ local defaultFramePriorities = {
"^oUF_.-Party", -- generic oUF
"^PitBull4_Groups_Party", -- pitbull4
"^XPerl_party%d", -- xperl
"^DandersRaidFrame", -- Danders
"^DandersFrames_Party", -- Danders
"^DandersFrames_Player$", -- Danders (used for party frames)
"^CompactRaid", -- blizz
"^CompactParty", -- blizz
"^PartyFrame",
Expand Down Expand Up @@ -132,6 +135,8 @@ local defaultPartyFrames = {
"^oUF_.-Party",
"^PitBull4_Groups_Party",
"^XPerl_party%d",
"^DandersFrames_Player$",
"^DandersFrames_Party",
"^PartyFrame",
"^CompactParty",
}
Expand Down Expand Up @@ -177,6 +182,7 @@ local defaultRaidFrames = {
"^SUFHeaderraid",
"^LUFHeaderraid",
"^XPerl_Raid_Grp",
"^DandersRaidFrame",
"^CompactRaid",
}
local getDefaultRaidFrames = function()
Expand Down Expand Up @@ -477,6 +483,9 @@ local function isFrameFiltered(name, ignoredFrames)
end

local function GetUnitFrames(target, ignoredFrames)
if issecretvalue(target) then
return
end
if not UnitExists(target) then
if type(target) ~= "string" then
return
Expand All @@ -494,7 +503,7 @@ local function GetUnitFrames(target, ignoredFrames)
local frames
for frame, frameName in pairs(FrameToFrameName.data) do
local unit = SecureButton_GetUnit(frame)
if unit and UnitIsUnit(unit, target) and not isFrameFiltered(frameName, ignoredFrames) then
if (not issecretvalue(unit)) and unit and (not issecretvalue(UnitIsUnit(unit, target))) and UnitIsUnit(unit, target) and not isFrameFiltered(frameName, ignoredFrames) then
frames = frames or {}
frames[frame] = frameName
end
Expand Down