Add forwardRef option to translate HOC to allow passing down ref#20
Open
soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
Open
Add forwardRef option to translate HOC to allow passing down ref#20soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
Conversation
soda0289
force-pushed
the
master
branch
2 times, most recently
from
ad14d9e to
159aae2
Compare
nayaabkhan
reviewed
Jun 14, 2021
| {t => <WrappedComponent {...props} t={t} />} | ||
| </I18nContext.Consumer> | ||
| ) | ||
| const _translate = originalProps => { |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace originalProps with (originalProps)
Suggested change
| const _translate = originalProps => { | |
| const _translate = (originalProps) => { |
nayaabkhan
reviewed
Jun 14, 2021
|
|
||
| return ( | ||
| <I18nContext.Consumer> | ||
| {t => <WrappedComponent {...props} t={t} ref={forwardedRef} />} |
Owner
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace t with (t)
Suggested change
| {t => <WrappedComponent {...props} t={t} ref={forwardedRef} />} | |
| {(t) => <WrappedComponent {...props} t={t} ref={forwardedRef} />} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a component is wrapped with translate() HOC it cannot have a ref passed into it. This commit adds an option called
forwardRefthat will use React.forwardRef to pass down the ref from the _translate component into the wrapped component.Still need to add tests but want to make sure this change is ok before working on it more.