Skip to content

feat(deploy-queue): Add heartbeat#75

Merged
Shugenya merged 25 commits intomainfrom
LKB-6942
Jan 21, 2026
Merged

feat(deploy-queue): Add heartbeat#75
Shugenya merged 25 commits intomainfrom
LKB-6942

Conversation

@Shugenya
Copy link
Contributor

@Shugenya Shugenya commented Dec 22, 2025

Deploy Queue cannot handle deployment cancellation in case there is runner failure. This results in stuck deployment that is blocking other deployments.

For those cases we'd like to introduce heartbeat - logic that is running and marking deployment as alive.

In this PR:

  • new column heartbeat_timestamp in deployments table
  • new CLI command for heartbeat
  • cancel stale deployments (where heartbeat is over the timeout threshold) before querying blocking deployments

@Shugenya Shugenya requested a review from jcgruenhage December 22, 2025 19:13
Copy link
Member

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start :)

@Shugenya
Copy link
Contributor Author

Shugenya commented Jan 5, 2026

@jcgruenhage
I am trying to understand the compatibility test failure - it's failing for tag v0.6.0.
When checking the files in this version: https://github.com/neondatabase/dev-actions/blob/deploy-queue-v0.6.0/deploy-queue/src/util/database.rs#L49 I see that .set_ignore_missing(true) was not yet used here. So the error is expected.
I don't understand why do we use 0.6.0 in the compatibility tests then? I assumed the idea was to use versions that already have that setting and make sure they still work even if there are new migrations applied.

Copy link
Member

@jcgruenhage jcgruenhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! :)

@Shugenya Shugenya marked this pull request as ready for review January 15, 2026 07:54
@Shugenya Shugenya requested a review from a team as a code owner January 15, 2026 07:54
@Shugenya Shugenya requested a review from bayandin January 19, 2026 10:45
Copy link
Contributor

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the Rust part (JC did it), but the comments are resolved and review looks ok — LGTM

@bayandin bayandin requested a review from jcgruenhage January 21, 2026 10:06
@bayandin bayandin dismissed jcgruenhage’s stale review January 21, 2026 10:06

We want to merge this PR

@Shugenya Shugenya merged commit 4bab6fa into main Jan 21, 2026
11 checks passed
@Shugenya Shugenya deleted the LKB-6942 branch January 21, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants