-
-
Notifications
You must be signed in to change notification settings - Fork 182
feat: font size picker #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexdln
wants to merge
7
commits into
npmx-dev:main
Choose a base branch
from
alexdln:feat/font-size-picker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+395
−52
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
84815b7
feat: implement font size picker
alexdln e5a2df7
feat: use font-size variables instead of fixed values
alexdln a8de08d
feat: restore tagline size
alexdln b60ee9a
feat: use select for text-size-picker
alexdln 2d38b6b
Merge branch 'main' into feat/font-size-picker
alexdln 1d14a8b
feat: add label for text-size select
alexdln 640c298
Merge branch 'feat/font-size-picker' of https://github.com/alexdln/np…
alexdln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| :root { | ||
| --text-9xl-font-size: 8rem; | ||
| --text-9xl-line-height: 1; | ||
| --text-8xl-font-size: 6rem; | ||
| --text-8xl-line-height: 1; | ||
| --text-7xl-font-size: 4.5rem; | ||
| --text-7xl-line-height: 1; | ||
| --text-6xl-font-size: 4rem; | ||
| --text-6xl-line-height: 1; | ||
| --text-5xl-font-size: 3rem; | ||
| --text-5xl-line-height: 1; | ||
| --text-4xl-font-size: 2.25rem; | ||
| --text-4xl-line-height: 2.5rem; | ||
| --text-3xl-font-size: 1.875rem; | ||
| --text-3xl-line-height: 2.25rem; | ||
| --text-2xl-font-size: 1.5rem; | ||
| --text-2xl-line-height: 2rem; | ||
| --text-xl-font-size: 1.25rem; | ||
| --text-xl-line-height: 1.75rem; | ||
| --text-lg-font-size: 1.125rem; | ||
| --text-lg-line-height: 1.75rem; | ||
| --text-base-font-size: 1rem; | ||
| --text-base-line-height: 1.5rem; | ||
| --text-sm-font-size: 0.875rem; | ||
| --text-sm-line-height: 1.25rem; | ||
| --text-xs-font-size: 0.75rem; | ||
| --text-xs-line-height: 1rem; | ||
| --text-2xs-font-size: 0.6875rem; | ||
| --text-2xs-line-height: 0.875rem; | ||
| --text-3xs-font-size: 0.625rem; | ||
| --text-3xs-line-height: 0.75rem; | ||
| --text-4xs-font-size: 0.5rem; | ||
| --text-4xs-line-height: 0.625rem; | ||
| } | ||
|
|
||
| html[data-text-size='largest'] { | ||
| --text-7xl-font-size: 6rem; | ||
| --text-7xl-line-height: 1; | ||
| --text-6xl-font-size: 6rem; | ||
| --text-6xl-line-height: 1; | ||
| --text-5xl-font-size: 4.5rem; | ||
| --text-5xl-line-height: 1; | ||
| --text-4xl-font-size: 4rem; | ||
| --text-4xl-line-height: 1; | ||
| --text-3xl-font-size: 3rem; | ||
| --text-3xl-line-height: 1; | ||
| --text-2xl-font-size: 2.25rem; | ||
| --text-2xl-line-height: 2.5rem; | ||
| --text-xl-font-size: 1.875rem; | ||
| --text-xl-line-height: 2.25rem; | ||
| --text-lg-font-size: 1.5rem; | ||
| --text-lg-line-height: 2rem; | ||
| --text-base-font-size: 1.25rem; | ||
| --text-base-line-height: 1.75rem; | ||
| --text-sm-font-size: 1.125rem; | ||
| --text-sm-line-height: 1.75rem; | ||
| --text-xs-font-size: 1rem; | ||
| --text-xs-line-height: 1.5rem; | ||
| --text-2xs-font-size: 0.875rem; | ||
| --text-2xs-line-height: 1.25rem; | ||
| --text-3xs-font-size: 0.75rem; | ||
| --text-3xs-line-height: 1rem; | ||
| --text-4xs-font-size: 0.6875rem; | ||
| --text-4xs-line-height: 0.875rem; | ||
| } | ||
|
|
||
| html[data-text-size='large'] { | ||
| --text-7xl-font-size: 6rem; | ||
| --text-7xl-line-height: 1; | ||
| --text-6xl-font-size: 4.5rem; | ||
| --text-6xl-line-height: 1; | ||
| --text-5xl-font-size: 4rem; | ||
| --text-5xl-line-height: 1; | ||
| --text-4xl-font-size: 3rem; | ||
| --text-4xl-line-height: 1; | ||
| --text-3xl-font-size: 2.25rem; | ||
| --text-3xl-line-height: 2.5rem; | ||
| --text-2xl-font-size: 1.875rem; | ||
| --text-2xl-line-height: 2.25rem; | ||
| --text-xl-font-size: 1.5rem; | ||
| --text-xl-line-height: 2rem; | ||
| --text-lg-font-size: 1.25rem; | ||
| --text-lg-line-height: 1.75rem; | ||
| --text-base-font-size: 1.125rem; | ||
| --text-base-line-height: 1.75rem; | ||
| --text-sm-font-size: 1rem; | ||
| --text-sm-line-height: 1.5rem; | ||
| --text-xs-font-size: 0.875rem; | ||
| --text-xs-line-height: 1.25rem; | ||
| --text-2xs-font-size: 0.75rem; | ||
| --text-2xs-line-height: 1rem; | ||
| --text-3xs-font-size: 0.6875rem; | ||
| --text-3xs-line-height: 0.875rem; | ||
| --text-4xs-font-size: 0.625rem; | ||
| --text-4xs-line-height: 0.75rem; | ||
| } | ||
|
|
||
| html[data-text-size='small'] { | ||
| --text-9xl-font-size: 6rem; | ||
| --text-9xl-line-height: 1; | ||
| --text-8xl-font-size: 4.5rem; | ||
| --text-8xl-line-height: 1; | ||
| --text-7xl-font-size: 4rem; | ||
| --text-7xl-line-height: 1; | ||
| --text-6xl-font-size: 3rem; | ||
| --text-6xl-line-height: 1; | ||
| --text-5xl-font-size: 2.25rem; | ||
| --text-5xl-line-height: 1; | ||
| --text-4xl-font-size: 1.875rem; | ||
| --text-4xl-line-height: 2.25rem; | ||
| --text-3xl-font-size: 1.5rem; | ||
| --text-3xl-line-height: 2rem; | ||
| --text-2xl-font-size: 1.25rem; | ||
| --text-2xl-line-height: 1.75rem; | ||
| --text-xl-font-size: 1.125rem; | ||
| --text-xl-line-height: 1.75rem; | ||
| --text-lg-font-size: 1rem; | ||
| --text-lg-line-height: 1.5rem; | ||
| --text-base-font-size: 0.875rem; | ||
| --text-base-line-height: 1.25rem; | ||
| --text-sm-font-size: 0.75rem; | ||
| --text-sm-line-height: 1rem; | ||
| --text-xs-font-size: 0.6875rem; | ||
| --text-xs-line-height: 0.875rem; | ||
| --text-2xs-font-size: 0.625rem; | ||
| --text-2xs-line-height: 0.75rem; | ||
| --text-3xs-font-size: 0.5rem; | ||
| --text-3xs-line-height: 0.625rem; | ||
| } | ||
|
|
||
| html[data-text-size='smallest'] { | ||
| --text-9xl-font-size: 4.5rem; | ||
| --text-9xl-line-height: 1; | ||
| --text-8xl-font-size: 4rem; | ||
| --text-8xl-line-height: 1; | ||
| --text-7xl-font-size: 3rem; | ||
| --text-7xl-line-height: 1; | ||
| --text-6xl-font-size: 2.25rem; | ||
| --text-6xl-line-height: 1; | ||
| --text-5xl-font-size: 1.875rem; | ||
| --text-5xl-line-height: 2.25rem; | ||
| --text-4xl-font-size: 1.5rem; | ||
| --text-4xl-line-height: 2rem; | ||
| --text-3xl-font-size: 1.25rem; | ||
| --text-3xl-line-height: 1.75rem; | ||
| --text-2xl-font-size: 1.125rem; | ||
| --text-2xl-line-height: 1.75rem; | ||
| --text-xl-font-size: 1rem; | ||
| --text-xl-line-height: 1.5rem; | ||
| --text-lg-font-size: 0.875rem; | ||
| --text-lg-line-height: 1.25rem; | ||
| --text-base-font-size: 0.75rem; | ||
| --text-base-line-height: 1rem; | ||
| --text-sm-font-size: 0.6875rem; | ||
| --text-sm-line-height: 0.875rem; | ||
| --text-xs-font-size: 0.625rem; | ||
| --text-xs-line-height: 0.75rem; | ||
| --text-2xs-font-size: 0.5625rem; | ||
| --text-2xs-line-height: 0.625rem; | ||
| --text-3xs-font-size: 0.5rem; | ||
| --text-3xs-line-height: 0.625rem; | ||
| } | ||
|
|
||
| body { | ||
| font-size: var(--text-base-font-size); | ||
| line-height: var(--text-base-line-height); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential iOS zoom issue on smaller text sizes.
The original
16pxvalue was likely chosen to prevent iOS Safari from auto-zooming inputs (iOS zooms when input font-size is below 16px). With thesmallesttext size setting,--text-base-font-sizebecomes0.75rem(12px), which may trigger unwanted auto-zoom on iOS devices when users focus inputs.Consider preserving the
16pxminimum or usingmax():🛠️ Suggested fix
`@media` screen and (max-width: 767px) { input, select, textarea { - font-size: var(--text-base-font-size) !important; - line-height: var(--text-base-line-height) !important; + font-size: max(16px, var(--text-base-font-size)) !important; + line-height: var(--text-base-line-height) !important; } }📝 Committable suggestion