[release-4.13] OCPSTRAT-659: DNS: Add awsPrivateHostedZoneRole

[patrickdillon]

4.13 backport of #1460

Adds a field to the DNS config to hold a role to assume when performing cross-account installs in an AWS shared VPC environment.

[openshift-ci]

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[mrunalp]

@JoelSpeed @deads2k ptal

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

This appears to be a backport of #1460

I would expect the original approvers to tag this too, CC @deads2k @Miciah

[Miciah]

/lgtm

[gcs278]

I've reviewed and also LGTM

[patrickdillon]

/hold
ready for review & tags but we need to line up the rest of the 4.13 backports to ship in a btach

[patrickdillon]

@deads2k @JoelSpeed
As part of this backport should I add privateHostedZoneAWS to the default feature set for 4.13? I'm not sure where we stand with that functionality in 4.13.

api/config/v1/types_feature.go

Line 200 in 61a5301

privateHostedZoneAWS,

[JoelSpeed]

As part of this backport should I add privateHostedZoneAWS to the default feature set for 4.13?

Was this feature introduced behind a feature gate, but then promoted to stable in 4.14? If the intention is for this backport to be available by default in 4.14, then backporting the feature gate to the stable set serves little purpose as far as I can tell

[JoelSpeed]

/approve
/label backport-risk-assessed

[openshift-ci]

@JoelSpeed: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Miciah, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

/retitle [release-4.13] OCPSTRAT-659: DNS: Add awsPrivateHostedZoneRole