Skip to content

Comments

CORS-2766: AWS Shared VPC API Bump [release-4.13]#337

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
patrickdillon:413-aws-shared-vpc
Aug 7, 2023
Merged

CORS-2766: AWS Shared VPC API Bump [release-4.13]#337
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
patrickdillon:413-aws-shared-vpc

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Jul 25, 2023

4.13 manual backport of aws-shared-vpc api bump

/hold
depends on openshift/api#1529

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@openshift-ci openshift-ci bot requested review from deads2k and soltysh July 25, 2023 18:30
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Aug 3, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Aug 3, 2023 •
edited by openshift-ci bot
Loading

/retitle CORS-2766: AWS Shared VPC API Bump [release-4.13]

@openshift-ci openshift-ci bot changed the title [release-4.13] AWS Shared VPC API bump CORS-2766: AWS Shared VPC API Bump [release-4.13] Aug 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 3, 2023 •
edited by openshift-ci bot
Loading

@patrickdillon: This pull request references CORS-2766 which is a valid jira issue.

Details

In response to this:

4.13 manual backport of aws-shared-vpc api bump

/hold
depends on openshift/api#1529

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yunjiang29 yunjiang29 mentioned this pull request Aug 7, 2023
Merged
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 7, 2023

/lgtm
/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@JoelSpeed: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/lgtm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit a9e658a into openshift:release-4.13 Aug 7, 2023
@patrickdillon patrickdillon mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@JoelSpeed JoelSpeed

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@patrickdillon @openshift-ci-robot @JoelSpeed @mrunalp @deads2k @xingxingxia @openshift-merge-robot @wangke19 @gangwgr