NO-JIRA: UPSTREAM: <carry>: Add manifests verify target

[RadekManak]

Summary

Add a verify target to ensure OCP manifests are generated correctly and no uncommitted changes exist after regeneration.

Changes

• Add openshift/provider-version.mk to define the provider version used for manifest generation
• Add openshift/verify-diff.sh script to verify no untracked files or uncommitted changes exist
• Add verify and verify-% Makefile targets to enable verification workflows
• Remove check-env dependency from ocp-manifests target (version now sourced from provider-version.mk)

Purpose

This enables CI to verify that generated OCP manifests are up-to-date by running make verify-ocp-manifests, which will:

1. Regenerate manifests via make ocp-manifests
2. Check for any uncommitted changes or untracked files
3. Fail if manifests are out of sync with the code

This prevents manifests from becoming stale when the provider version or manifest generation logic changes.

Testing

The verify job will be automatically triggered by CI once the corresponding PR in openshift/release (openshift/release#71392) is merged.

[openshift-ci-robot]

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Add a verify target to ensure OCP manifests are generated correctly and no uncommitted changes exist after regeneration.

Changes

• Add openshift/provider-version.mk to define the provider version used for manifest generation
• Add openshift/verify-diff.sh script to verify no untracked files or uncommitted changes exist
• Add verify and verify-% Makefile targets to enable verification workflows
• Remove check-env dependency from ocp-manifests target (version now sourced from provider-version.mk)

Purpose

This enables CI to verify that generated OCP manifests are up-to-date by running make verify-ocp-manifests, which will:

1. Regenerate manifests via make ocp-manifests
2. Check for any uncommitted changes or untracked files
3. Fail if manifests are out of sync with the code

This prevents manifests from becoming stale when the provider version or manifest generation logic changes.

Testing

The verify job will be automatically triggered by CI once the corresponding PR in openshift/release (openshift/release#71392) is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/approve
/lgtm

[mdbooth]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mdbooth, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [RadekManak,damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/override ci/prow/e2e-vsphere-serial

Unrelated

[openshift-ci]

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-vsphere-serial

Details

In response to this:

/override ci/prow/e2e-vsphere-serial

Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

/verified by @damdo

[openshift-ci-robot]

@damdo: This PR has been marked as verified by @damdo.

Details

In response to this:

/verified by @damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.