Skip to content

Fake bump to test kms #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ardaguclu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fake bump to test kms #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require (
github.com/google/go-cmp v0.7.0
github.com/onsi/ginkgo/v2 v2.21.0
github.com/openshift-eng/openshift-tests-extension v0.0.0-20251205182537-ff5553e56f33
github.com/openshift/api v0.0.0-20260126183958-606bd613f9f7
github.com/openshift/api v0.0.0-20260212193555-c06ab675261f
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee
github.com/openshift/client-go v0.0.0-20260108185524-48f4ccfc4e13
github.com/openshift/library-go v0.0.0-20260210145149-d0e860e8d752
Expand Down Expand Up @@ -131,4 +131,7 @@ require (
sigs.k8s.io/yaml v1.6.0 // indirect
)

replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1
replace (
github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1
github.com/openshift/library-go => github.com/ardaguclu/library-go v0.0.0-20260217073437-5a7a2b2a33d9
)
Comment on lines 134 to 137
Copy link

@coderabbitai coderabbitai bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, let's check the repository context and understand the go.mod file
pwd
git ls-files go.mod | head -20

Repository: openshift/cluster-authentication-operator

Length of output: 110

🏁 Script executed:

# Check the full go.mod file to understand the context
head -150 go.mod | tail -50

Repository: openshift/cluster-authentication-operator

Length of output: 2590

🏁 Script executed:

# Look for any PR metadata or documentation files
git ls-files | grep -E "(DESCRIPTION|PR|NOTES|TODO|README)" | head -20

Repository: openshift/cluster-authentication-operator

Length of output: 955

🏁 Script executed:

# Search for any comments or TODOs mentioning library-go or kms
rg -i "library-go|kms" --type md --type txt -A 2 -B 2

Repository: openshift/cluster-authentication-operator

Length of output: 15965

🏁 Script executed:

# Check git log for this specific change
git log --all --oneline --grep="library-go" -i | head -10
git log --all --oneline --grep="kms" -i | head -10

Repository: openshift/cluster-authentication-operator

Length of output: 1138

🏁 Script executed:

# Check if there are any CI/CD configuration files that might indicate test-only status
git ls-files | grep -E "(\.github|\.gitlab|\.circleci|Makefile|\.mk)" | head -20

Repository: openshift/cluster-authentication-operator

Length of output: 1099

🏁 Script executed:

# Check current branch and which branches contain this commit
git rev-parse --abbrev-ref HEAD
git branch -a --contains 8fa97618

# Check the most recent commit on main/master
git log main --oneline -1 2>/dev/null || git log master --oneline -1

# Check if the replace directive change is in the current default branch
git show main:go.mod 2>/dev/null | grep -A 5 "^replace" || git show master:go.mod 2>/dev/null | grep -A 5 "^replace"

Repository: openshift/cluster-authentication-operator

Length of output: 289

🏁 Script executed:

# Check the status of the working directory to see if go.mod has uncommitted changes
git status go.mod

# Show the current go.mod replace directive
git show HEAD:go.mod | grep -A 5 "^replace"

Repository: openshift/cluster-authentication-operator

Length of output: 368

🏁 Script executed:

# Look for any PR or issue context that might indicate this is temporary
# Check for any TODO, FIXME, or comments about reverting this change
rg -i "TODO|FIXME|revert|temporary|temp" go.mod -B 3 -A 3
git log --all --grep="revert\|temporary\|temp" -i --oneline | grep -i library-go

Repository: openshift/cluster-authentication-operator

Length of output: 67

Remove personal fork replacement before merging to production.

The replace directive points github.com/openshift/library-go to a personal fork (github.com/ardaguclu/library-go). While the commit message confirms this is for testing KMS functionality, this must be reverted before merging to the master branch, as personal forks introduce security risks (potential supply chain vulnerabilities) and maintainability issues (forks may diverge from the official library). Ensure the original github.com/openshift/library-go is restored in the final version.

🤖 Prompt for AI Agents 
In `@go.mod` around lines 134 - 137, The go.mod replace directive temporarily
points github.com/openshift/library-go to a personal fork
(github.com/ardaguclu/library-go); remove that replace entry (or change it to
the official module/version) so the project depends on the upstream
github.com/openshift/library-go instead of the personal fork, ensuring the
replace block no longer references github.com/ardaguclu/library-go.

8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ github.com/RangelReale/osincli v0.0.0-20160924135400-fababb0555f2 h1:x8Brv0YNEe6
github.com/RangelReale/osincli v0.0.0-20160924135400-fababb0555f2/go.mod h1:XyjUkMA8GN+tOOPXvnbi3XuRxWFvTJntqvTFnjmhzbk=
github.com/antlr4-go/antlr/v4 v4.13.0 h1:lxCg3LAv+EUK6t1i0y1V6/SLeUi0eKEKdhQAlS8TVTI=
github.com/antlr4-go/antlr/v4 v4.13.0/go.mod h1:pfChB/xh/Unjila75QW7+VU4TSnWnnk9UTnmpPaOR2g=
github.com/ardaguclu/library-go v0.0.0-20260217073437-5a7a2b2a33d9 h1:10+ya2kK81TM4kPpmIa7YRRt3dgfwGYMgxgF9KodHhQ=
github.com/ardaguclu/library-go v0.0.0-20260217073437-5a7a2b2a33d9/go.mod h1:K3FoNLgNBFYbFuG+Kr8usAnQxj1w84XogyUp2M8rK8k=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=
Expand Down Expand Up @@ -146,14 +148,12 @@ github.com/onsi/gomega v1.35.1 h1:Cwbd75ZBPxFSuZ6T+rN/WCb/gOc6YgFBXLlZLhC7Ds4=
github.com/onsi/gomega v1.35.1/go.mod h1:PvZbdDc8J6XJEpDK4HCuRBm8a6Fzp9/DmhC9C7yFlog=
github.com/openshift-eng/openshift-tests-extension v0.0.0-20251205182537-ff5553e56f33 h1:LJf6kWZQ36iako7WXRzdEa5XKrnyrAX8GBhlAcKRaZQ=
github.com/openshift-eng/openshift-tests-extension v0.0.0-20251205182537-ff5553e56f33/go.mod h1:6gkP5f2HL0meusT0Aim8icAspcD1cG055xxBZ9yC68M=
github.com/openshift/api v0.0.0-20260126183958-606bd613f9f7 h1:96rhgJpWlWzKEslMd6aYFMixV9vQVY32M71JcO4Gzn0=
github.com/openshift/api v0.0.0-20260126183958-606bd613f9f7/go.mod h1:d5uzF0YN2nQQFA0jIEWzzOZ+edmo6wzlGLvx5Fhz4uY=
github.com/openshift/api v0.0.0-20260212193555-c06ab675261f h1:l1IgsK48Ym/nED30yfaCTF4MtswO1eOoyfXgh2rEmdw=
github.com/openshift/api v0.0.0-20260212193555-c06ab675261f/go.mod h1:d5uzF0YN2nQQFA0jIEWzzOZ+edmo6wzlGLvx5Fhz4uY=
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee h1:+Sp5GGnjHDhT/a/nQ1xdp43UscBMr7G5wxsYotyhzJ4=
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee/go.mod h1:8jcm8UPtg2mCAsxfqKil1xrmRMI3a+XU2TZ9fF8A7TE=
github.com/openshift/client-go v0.0.0-20260108185524-48f4ccfc4e13 h1:6rd4zSo2UaWQcAPZfHK9yzKVqH0BnMv1hqMzqXZyTds=
github.com/openshift/client-go v0.0.0-20260108185524-48f4ccfc4e13/go.mod h1:YvOmPmV7wcJxpfhTDuFqqs2Xpb3M3ovsM6Qs/i2ptq4=
github.com/openshift/library-go v0.0.0-20260210145149-d0e860e8d752 h1:KQj7j9VpMzv+gYerCgA9CbPehwGO3ARUg+B2Pt1YcWs=
github.com/openshift/library-go v0.0.0-20260210145149-d0e860e8d752/go.mod h1:DCRz1EgdayEmr9b6KXKDL+DWBN0rGHu/VYADeHzPoOk=
github.com/openshift/multi-operator-manager v0.0.0-20241205181422-20aa3906b99d h1:Rzx23P63JFNNz5D23ubhC0FCN5rK8CeJhKcq5QKcdyU=
github.com/openshift/multi-operator-manager v0.0.0-20241205181422-20aa3906b99d/go.mod h1:iVi9Bopa5cLhjG5ie9DoZVVqkH8BGb1FQVTtecOLn4I=
github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 h1:PMTgifBcBRLJJiM+LgSzPDTk9/Rx4qS09OUrfpY6GBQ=
Expand Down
1 change: 1 addition & 0 deletions vendor/github.com/openshift/api/.coderabbit.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/github.com/openshift/api/apiextensions/v1alpha1/types_compatibilityrequirement.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ...hub.com/openshift/api/apiextensions/v1alpha1/zz_generated.featuregated-crd-manifests.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/github.com/openshift/api/config/v1/types_insights.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions vendor/github.com/openshift/api/config/v1/types_network.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 14 additions & 35 deletions vendor/github.com/openshift/api/config/v1/types_tlssecurityprofile.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading