CCXDEV-1560 - Optimize the CPU usage of insights-runtime-extractor#1220
CCXDEV-1560 - Optimize the CPU usage of insights-runtime-extractor#1220jmesnil wants to merge 3 commits intoopenshift:masterfrom
Conversation
Add the PRD that describe the required changes in the Insights Operator. The changes to the insights-runtime-extractor are handled in openshift/insights-runtime-extractor#60. JIRA: https://issues.redhat.com/browse/CCXDEV-15960 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmesnil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| Leverage the new POST endpoint in insights-runtime-extractor that accepts a list of container IDs to scan. The insights-operator will: | ||
|
|
||
| 1. Determine which container IDs are needed based on the pods it's processing | ||
| 2. Send only those container IDs to the insights-runtime-extractor via POST request |
There was a problem hiding this comment.
Would batching those requests, instead of sending all 8000 IDs in a single POST, add here any benefits?
There was a problem hiding this comment.
POSTing at most 8000 ids would send a request of maximum 600KB.
I'm not sure that it is worth splitting that into several requests though... But if you want to make that a requirement from the Insights Operator, it's doable
jmesnil
force-pushed
the
CCXDEV-15960
branch
3 times, most recently
from
827f2b7 to
18ed0ab
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Implementation Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@jmesnil: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Add the PRD that describe the required changes in the Insights Operator.
The changes to the insights-runtime-extractor are handled in openshift/insights-runtime-extractor#60.
JIRA: https://issues.redhat.com/browse/CCXDEV-15960
Changelog
Integration of the insights-runtime-extractor and its API have been changed to collect only runtime data
from the subset of containers that are gathered by the Insights Operator
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-15960