[CCXDEV-15960] Optimize the CPU usage of insights-runtime-extractor#60
Open
jmesnil wants to merge 6 commits intoopenshift:mainfrom
Open
[CCXDEV-15960] Optimize the CPU usage of insights-runtime-extractor#60jmesnil wants to merge 6 commits intoopenshift:mainfrom
jmesnil wants to merge 6 commits intoopenshift:mainfrom
Conversation
The insights-runtime-extractor must be able to scan only a subset of containers (requested by the Insights Operator) instead of collecting data for *all* containers when the Insights Operator has a hard limit on number of containers that are gathered. This addresses https://issues.redhat.com/browse/CCXDEV-15960. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
The coordinator executable now accepts a comma-separated list of container ID that needs to be collected. If this list is empty, *all* running containers are collected. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
When a TCP connection is created, read a String that is expected to contain a list of container IDs. If the string is empty (as was previously the case), all containers on the node are scanned. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Add POST /gather_runtime_info endpoint that accepts a JSON body with containerIds array to scan specific containers. The container IDs are sent as comma-separated values over TCP to the extractor server. Uses CloseWrite() to signal EOF for proper TCP stream handling. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmesnil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
Author
|
/retest |
jmesnil
added a commit
to jmesnil/insights-operator
that referenced
this pull request
Feb 2, 2026
Add the PRD that describe the required changes in the Insights Operator. The changes to the insights-runtime-extractor are handled in openshift/insights-runtime-extractor#60. JIRA: https://issues.redhat.com/browse/CCXDEV-15960 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jmesnil
added a commit
to jmesnil/insights-operator
that referenced
this pull request
Feb 2, 2026
Add the PRD that describe the required changes in the Insights Operator. The changes to the insights-runtime-extractor are handled in openshift/insights-runtime-extractor#60. JIRA: https://issues.redhat.com/browse/CCXDEV-15960 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Open
1 task
Contributor
Author
|
/retest |
4 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
|
@jmesnil: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to collect runtime data for a subset of containers that will be requested by the Insights Operator.
It also requires changes in the Insights Operator that will be done in openshift/insights-operator#1220
The changes are backwards compatible so that this PR can be merged before the code of the insights operator is updated.
JIRA: https://issues.redhat.com/browse/CCXDEV-15960