OCPBUGS-13547: remove special cases for featureset in rendering

[deads2k]

This completes the reset for rendering featureset sensitive manifests based on the FeatureGate manifest provided by the cluster-config-operator.

[deads2k]

• could not run steps: step installer-artifacts failed: error occurred handling build installer-artifacts: build didn't start running within 30m0s (phase: Running):
  Found 17 events for Pod installer-artifacts-build:

/retest

[patrickdillon]

• could not run steps: step installer-artifacts failed: error occurred handling build installer-artifacts: build didn't start running within 30m0s (phase: Running):
  Found 17 events for Pod installer-artifacts-build:

/retest

Revert for the cause is being floated here: openshift/ci-tools#3409

I'm also floating #7159 for discussion.

[deads2k]

/retest

[deads2k]

/retest

[patrickdillon]

I'm a bit confused about the relationship between this and #7152. Do we still need this?

[patrickdillon]

Deleting these three lines is not covered by #7152

[deads2k]

Yes, trying to remove the --feature-set from our render commands. #7152 is more important, but this is also desired

[JoelSpeed]

/lgtm

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

last installer change for the cluster-config-operator. MCO may need a rendering flag passed. Adding label.

A secondary benefit of this approach is that we now have a way to pass the config.openshift.io resources to rendering without individual flags for each render command. This is a good approach to solving the disparate flag sprawl and moving towards contract stability.

[deads2k]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4599c85 and 2 for PR HEAD e1f2157 in total

[openshift-ci]

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	e1f2157	link	false	/test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn	e1f2157	link	false	/test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

@deads2k This broke the feature gate manifest generation process and I think has broken installations.

While the manifest file path you removed here has a full path when it writes out, the paths for the feature gate files found by the generic/path walk approach we have, return a relative path to the rendered path, so when we write out using OriginalFileName it writes the file directly to CWD rather than the original path. Any idea why original file name shouldn't be the absolute path?

[openshift-ci-robot]

@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:

• openshift/cluster-cloud-controller-manager-operator#249
• openshift/machine-config-operator#3701

The following pull requests linked via external trackers have not merged:

• openshift/installer#7160 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state.

Details

In response to this:

This completes the reset for rendering featureset sensitive manifests based on the FeatureGate manifest provided by the cluster-config-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.