Skip to content

Comments

WIP: Rebase 1.35#2055

Open
jacobsee wants to merge 4 commits intoopenshift:masterfrom
jacobsee:rebase-1.35
Open

WIP: Rebase 1.35#2055
jacobsee wants to merge 4 commits intoopenshift:masterfrom
jacobsee:rebase-1.35

Conversation

@jacobsee
Copy link
Member

@jacobsee jacobsee commented Nov 19, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and deads2k November 19, 2025 22:09
@jacobsee jacobsee force-pushed the rebase-1.35 branch 3 times, most recently from abe97a4 to b5b32f8 Compare December 4, 2025 20:22
@jacobsee
Copy link
Member Author

jacobsee commented Dec 12, 2025

/retest

This was referenced Jan 7, 2026
Merged
Closed
p0lyn0mial
p0lyn0mial reviewed Jan 28, 2026
View reviewed changes
go.mod
sigs.k8s.io/yaml v1.6.0
)

replace (
Copy link
Contributor

@p0lyn0mial p0lyn0mial Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to remove the replacements.

Copy link
Member Author

@jacobsee jacobsee Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks, they'll be removed. They are only currently necessary for checking CI while openshift/api#2578 and openshift/client-go#346 have not merged.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobsee
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2026

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@deads2k deads2k Awaiting requested review from deads2k

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobsee @p0lyn0mial