Conversation
There was a problem hiding this comment.
Pull request overview
Pins this repository’s GitHub Actions reusable-workflow references to a specific parcelLab/ci release instead of the moving major tag.
Changes:
- Updated reusable workflow
uses:refs from@v8to@v8.3.3across CI and deployment-related workflows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/kubernetes.yaml | Pins the build-image reusable workflow reference to v8.3.3. |
| .github/workflows/ci.yaml.yaml | Pins the YAML lint reusable workflow reference to v8.3.3. |
| .github/workflows/ci.release.yaml | Pins the release reusable workflow reference to v8.3.3. |
| .github/workflows/ci.pr.yaml | Pins PR and yamllint reusable workflow references to v8.3.3. |
| .github/workflows/ci.json.yaml | Pins the JSON lint reusable workflow reference to v8.3.3. |
| jobs: | ||
| lint: | ||
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3 |
There was a problem hiding this comment.
Pinning this workflow call to @v8.3.3 means it will no longer follow the repo’s major-tag update mechanism (the update-major-tag job in .github/workflows/ci.release.yaml keeps v8 pointing at the latest v8.x.y). Without an automated updater (no Dependabot config found in .github/), this will become stale over time. Consider reverting to @v8 if you want automatic patch/minor uptake.
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3 | |
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8 |
| git push origin tag "${{ steps.version.outputs.major_version }}" | ||
| release: | ||
| uses: parcelLab/ci/.github/workflows/release.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3 |
There was a problem hiding this comment.
This workflow itself contains logic to keep the major tag (e.g., v8) updated to the latest full tag, but the release job is now pinned to @v8.3.3. That defeats the purpose of maintaining a moving major tag for internal reuse and will require manual updates for every patch/minor release (and there’s no Dependabot config in .github/ to automate that). If the goal is to track the latest v8 release, prefer @v8 here.
| uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3 | |
| uses: parcelLab/ci/.github/workflows/release.yaml@v8 |
| jobs: | ||
| pr: | ||
| uses: parcelLab/ci/.github/workflows/pr.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/pr.yaml@v8.3.3 |
There was a problem hiding this comment.
Pinning to @v8.3.3 opts out of the repo’s moving major-tag strategy (the update-major-tag job in .github/workflows/ci.release.yaml updates v8 to the latest v8.x.y). With no Dependabot config present to bump these pins, this will require manual updates to keep consuming fixes. Consider switching back to @v8 if automatic updates are desired.
| run: /home/runner/go/bin/actionlint | ||
| yamllint: | ||
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3 |
There was a problem hiding this comment.
Same concern as the other pinned reusable-workflow refs: pinning to @v8.3.3 means you won’t automatically pick up future v8 patch/minor releases even though the repo maintains a moving v8 tag (updated in .github/workflows/ci.release.yaml). Without Dependabot config, this will need manual bumps. Consider using @v8 if you want the latest v8 behavior.
| jobs: | ||
| lint: | ||
| uses: parcelLab/ci/.github/workflows/json.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3 |
There was a problem hiding this comment.
Pinning this reusable workflow ref to @v8.3.3 bypasses the repo’s moving v8 tag (maintained by .github/workflows/ci.release.yaml) and will require manual updates to pick up future fixes (no Dependabot config found to automate bumps). Consider using @v8 if the intent is to always run against the latest v8 release.
| uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3 | |
| uses: parcelLab/ci/.github/workflows/json.yaml@v8 |
| build: | ||
| needs: [initialize] | ||
| uses: parcelLab/ci/.github/workflows/build-image.yaml@v8 | ||
| uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3 |
There was a problem hiding this comment.
This repo already maintains a moving major tag (e.g., v8) that is updated to the latest full release via the update-major-tag job in .github/workflows/ci.release.yaml (see Extract/Update major version steps). Pinning this uses: ref to v8.3.3 bypasses that mechanism and will require manual bumps for future patch/minor releases (there’s no Dependabot config in .github/ to automate updates). Consider switching back to @v8 if the intent is to always run the latest v8 release, or add automation for keeping these pinned refs updated.
| uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3 | |
| uses: parcelLab/ci/.github/workflows/build-image.yaml@v8 |
|
moved the v8 tag |
No description provided.