Skip to content

fix: pin to latest release#80

Closed
andibeuge wants to merge 1 commit intomainfrom
fix/pin-latest-release
Closed

fix: pin to latest release#80
andibeuge wants to merge 1 commit intomainfrom
fix/pin-latest-release

Conversation

@andibeuge
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 15:37
@andibeuge andibeuge requested a review from a team as a code owner March 9, 2026 15:37
@github-actions github-actions bot added the ci label Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins this repository’s GitHub Actions reusable-workflow references to a specific parcelLab/ci release instead of the moving major tag.

Changes:

  • Updated reusable workflow uses: refs from @v8 to @v8.3.3 across CI and deployment-related workflows.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.github/workflows/kubernetes.yaml Pins the build-image reusable workflow reference to v8.3.3.
.github/workflows/ci.yaml.yaml Pins the YAML lint reusable workflow reference to v8.3.3.
.github/workflows/ci.release.yaml Pins the release reusable workflow reference to v8.3.3.
.github/workflows/ci.pr.yaml Pins PR and yamllint reusable workflow references to v8.3.3.
.github/workflows/ci.json.yaml Pins the JSON lint reusable workflow reference to v8.3.3.

jobs:
lint:
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning this workflow call to @v8.3.3 means it will no longer follow the repo’s major-tag update mechanism (the update-major-tag job in .github/workflows/ci.release.yaml keeps v8 pointing at the latest v8.x.y). Without an automated updater (no Dependabot config found in .github/), this will become stale over time. Consider reverting to @v8 if you want automatic patch/minor uptake.

Suggested change
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8

Copilot uses AI. Check for mistakes.
git push origin tag "${{ steps.version.outputs.major_version }}"
release:
uses: parcelLab/ci/.github/workflows/release.yaml@v8
uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow itself contains logic to keep the major tag (e.g., v8) updated to the latest full tag, but the release job is now pinned to @v8.3.3. That defeats the purpose of maintaining a moving major tag for internal reuse and will require manual updates for every patch/minor release (and there’s no Dependabot config in .github/ to automate that). If the goal is to track the latest v8 release, prefer @v8 here.

Suggested change
uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/release.yaml@v8

Copilot uses AI. Check for mistakes.
jobs:
pr:
uses: parcelLab/ci/.github/workflows/pr.yaml@v8
uses: parcelLab/ci/.github/workflows/pr.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to @v8.3.3 opts out of the repo’s moving major-tag strategy (the update-major-tag job in .github/workflows/ci.release.yaml updates v8 to the latest v8.x.y). With no Dependabot config present to bump these pins, this will require manual updates to keep consuming fixes. Consider switching back to @v8 if automatic updates are desired.

Copilot uses AI. Check for mistakes.
run: /home/runner/go/bin/actionlint
yamllint:
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as the other pinned reusable-workflow refs: pinning to @v8.3.3 means you won’t automatically pick up future v8 patch/minor releases even though the repo maintains a moving v8 tag (updated in .github/workflows/ci.release.yaml). Without Dependabot config, this will need manual bumps. Consider using @v8 if you want the latest v8 behavior.

Copilot uses AI. Check for mistakes.
jobs:
lint:
uses: parcelLab/ci/.github/workflows/json.yaml@v8
uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning this reusable workflow ref to @v8.3.3 bypasses the repo’s moving v8 tag (maintained by .github/workflows/ci.release.yaml) and will require manual updates to pick up future fixes (no Dependabot config found to automate bumps). Consider using @v8 if the intent is to always run against the latest v8 release.

Suggested change
uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/json.yaml@v8

Copilot uses AI. Check for mistakes.
build:
needs: [initialize]
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo already maintains a moving major tag (e.g., v8) that is updated to the latest full release via the update-major-tag job in .github/workflows/ci.release.yaml (see Extract/Update major version steps). Pinning this uses: ref to v8.3.3 bypasses that mechanism and will require manual bumps for future patch/minor releases (there’s no Dependabot config in .github/ to automate updates). Consider switching back to @v8 if the intent is to always run the latest v8 release, or add automation for keeping these pinned refs updated.

Suggested change
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8

Copilot uses AI. Check for mistakes.
@andibeuge
Copy link
Contributor Author

moved the v8 tag

@andibeuge andibeuge closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants