Skip to content

fix: pin to latest release #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andibeuge wants to merge 1 commit into from
Closed

fix: pin to latest release #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.json.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ on:
workflow_dispatch:
jobs:
lint:
uses: parcelLab/ci/.github/workflows/json.yaml@v8
uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning this reusable workflow ref to @v8.3.3 bypasses the repo’s moving v8 tag (maintained by .github/workflows/ci.release.yaml) and will require manual updates to pick up future fixes (no Dependabot config found to automate bumps). Consider using @v8 if the intent is to always run against the latest v8 release.

Suggested change
uses: parcelLab/ci/.github/workflows/json.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/json.yaml@v8

Copilot uses AI. Check for mistakes.
4 changes: 2 additions & 2 deletions .github/workflows/ci.pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- synchronize
jobs:
pr:
uses: parcelLab/ci/.github/workflows/pr.yaml@v8
uses: parcelLab/ci/.github/workflows/pr.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to @v8.3.3 opts out of the repo’s moving major-tag strategy (the update-major-tag job in .github/workflows/ci.release.yaml updates v8 to the latest v8.x.y). With no Dependabot config present to bump these pins, this will require manual updates to keep consuming fixes. Consider switching back to @v8 if automatic updates are desired.

Copilot uses AI. Check for mistakes.
secrets:
repoAccessToken: ${{ secrets.GITHUB_TOKEN }}
actionlint:
Expand All @@ -24,4 +24,4 @@ jobs:
- name: Run actionlint
run: /home/runner/go/bin/actionlint
yamllint:
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as the other pinned reusable-workflow refs: pinning to @v8.3.3 means you won’t automatically pick up future v8 patch/minor releases even though the repo maintains a moving v8 tag (updated in .github/workflows/ci.release.yaml). Without Dependabot config, this will need manual bumps. Consider using @v8 if you want the latest v8 behavior.

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion .github/workflows/ci.release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ jobs:
git tag "${{ steps.version.outputs.major_version }}"
git push origin tag "${{ steps.version.outputs.major_version }}"
release:
uses: parcelLab/ci/.github/workflows/release.yaml@v8
uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow itself contains logic to keep the major tag (e.g., v8) updated to the latest full tag, but the release job is now pinned to @v8.3.3. That defeats the purpose of maintaining a moving major tag for internal reuse and will require manual updates for every patch/minor release (and there’s no Dependabot config in .github/ to automate that). If the goal is to track the latest v8 release, prefer @v8 here.

Suggested change
uses: parcelLab/ci/.github/workflows/release.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/release.yaml@v8

Copilot uses AI. Check for mistakes.
secrets:
repoAccessToken: ${{ secrets.REPO_ACCESS_TOKEN_OPEN_SOURCE }}
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ on:
workflow_dispatch:
jobs:
lint:
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning this workflow call to @v8.3.3 means it will no longer follow the repo’s major-tag update mechanism (the update-major-tag job in .github/workflows/ci.release.yaml keeps v8 pointing at the latest v8.x.y). Without an automated updater (no Dependabot config found in .github/), this will become stale over time. Consider reverting to @v8 if you want automatic patch/minor uptake.

Suggested change
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/yaml.yaml@v8

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion .github/workflows/kubernetes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ jobs:

build:
needs: [initialize]
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo already maintains a moving major tag (e.g., v8) that is updated to the latest full release via the update-major-tag job in .github/workflows/ci.release.yaml (see Extract/Update major version steps). Pinning this uses: ref to v8.3.3 bypasses that mechanism and will require manual bumps for future patch/minor releases (there’s no Dependabot config in .github/ to automate updates). Consider switching back to @v8 if the intent is to always run the latest v8 release, or add automation for keeping these pinned refs updated.

Suggested change
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8.3.3
uses: parcelLab/ci/.github/workflows/build-image.yaml@v8

Copilot uses AI. Check for mistakes.
with:
artifactName: ${{ inputs.artifactName }}
artifactPath: ${{ inputs.artifactPath }}
Expand Down